fix(s3-notifications): lambda destination creates a circular dependency when bucket and lambda are in different stacks#10426
Merged
mergify[bot] merged 14 commits intomasterfrom Sep 21, 2020
Conversation
…ent circular dependency
nija-at
previously approved these changes
Sep 18, 2020
Contributor
nija-at
left a comment
There was a problem hiding this comment.
maybe drop the text "from bucket notification" in the title to make it a little terser.
iliapolo
commented
Sep 18, 2020
iliapolo
commented
Sep 18, 2020
nija-at
approved these changes
Sep 21, 2020
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
njlynch
approved these changes
Sep 21, 2020
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the bucket and function are in two different stacks, the following stacks are created:
Bucket Stack
s3.Buckets3.BucketNotificationHandler(creates a dependency on lambda stack since it configures the target of the trigger)Lambda Stack
lambda.Functionlambda.Permission(creates a dependency on the bucket stack since it configures the lambda to allow invocations from that specific bucket)The solution is to switch up the
lambda.Permissionscope and use the bucket instead of the function, so that it is added to the bucket stack, leaving the lambda stack independent.Fixes #5760
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license