-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
@aws-cdk/assetsRelated to the @aws-cdk/assets packageRelated to the @aws-cdk/assets packageeffort/smallSmall work item – less than a day of effortSmall work item – less than a day of effortfeature-requestA feature should be added or improved.A feature should be added or improved.good first issueRelated to contributions. See CONTRIBUTING.mdRelated to contributions. See CONTRIBUTING.md
Description
🚀 Feature Request
General Information
- 👋 I may be able to implement this feature request
-
⚠️ This feature might incur a breaking change
Description
I have a project where multiple dockerfiles have the same build context. In this case, it would be nice to be able to pass in the dockerfile name. (I'm taking about the -f parameter in docker build)
Proposed Solution
In the prepareContainerAsset method,
aws-cdk/packages/aws-cdk/lib/docker.ts
Lines 65 to 70 in 4afd40e
| const baseCommand = [ | |
| 'docker', 'build', | |
| ...buildArgs, | |
| '--tag', latest, | |
| contextPath | |
| ]; |
it's missing the
-f parameter which could default to something like $path/Dockerfile.
Environment
- CDK CLI Version: 1.6.0
- Module Version:
- OS: all
- Language: all
Other information
Similar feature request: #3342 where a custom build context is being requested.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
@aws-cdk/assetsRelated to the @aws-cdk/assets packageRelated to the @aws-cdk/assets packageeffort/smallSmall work item – less than a day of effortSmall work item – less than a day of effortfeature-requestA feature should be added or improved.A feature should be added or improved.good first issueRelated to contributions. See CONTRIBUTING.mdRelated to contributions. See CONTRIBUTING.md