fix(s3-deployment): handle empty string in Source.data() #35824
Merged
mergify[bot] merged 3 commits intomainfrom Oct 23, 2025
Merged
fix(s3-deployment): handle empty string in Source.data() #35824mergify[bot] merged 3 commits intomainfrom
mergify[bot] merged 3 commits intomainfrom
Conversation
- Add explicit handling for empty string input in renderData - Prevent potential errors when processing empty string data - Add regression test for empty string Source.data scenario - Resolve issue #35809 related to empty string data handling
kumvprat
approved these changes
Oct 23, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 task
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #35809.
Original PR: #35818
This PR is been created to fasten release of the fix for the p0
Reason for this change
Source.data()fails with a TypeError when called with an empty string as the data parameter in CDK v2.207.0+. This is a regression from v2.206.0 where empty string deployment worked correctly.The issue manifests as:
Description of changes
This change handles the the case from renderData function.
Describe any new or updated permissions being added
Description of how you validated changes
Unit tests have been added to cover this case and integ test has also been updated.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license