fix(kms): Alias reference incorrectly resolves to underlying Key#35545
Merged
mergify[bot] merged 2 commits intomainfrom Sep 22, 2025
Merged
fix(kms): Alias reference incorrectly resolves to underlying Key#35545mergify[bot] merged 2 commits intomainfrom
Alias reference incorrectly resolves to underlying Key#35545mergify[bot] merged 2 commits intomainfrom
Conversation
Because `IAlias` extends `IKey`, `IAlias` inherits the new `keyRef: KeyReference`. It was originally implemented by referencing the underlying key, but that's wrong: it should reference the alias itself, but using the field names it shares with `IKey`. In fact, we should have introduced a new interface like `IKeyLike` to do this job, but instead we overloaded `IKey` to behave like a hypothetical `IKeyLike`, and `IKeyRef` now inherits this double duty. Therefore, we now make the `IKeyRef` implementation of `Alias` behave like a `IKeyLikeRef`, and satisfy the contract using its own fields.
aws-cdk-automation
previously requested changes
Sep 22, 2025
mrgrain
approved these changes
Sep 22, 2025
Alias reference incorrectly resolves to underlying Key
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
added a commit
that referenced
this pull request
Sep 22, 2025
The `IFunctionRef` implementation of `LatestVersion` returns the underlying function ARN, instead of the version's ARN. This is a similar situation and fix to #35545.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
IAliasextendsIKey,IAliasinherits the newkeyRef: KeyReference.It was originally implemented by referencing the underlying key, but that's wrong: it should reference the alias itself, but using the field names it shares with
IKey.In fact, we should have introduced a new interface like
IKeyLiketo do this job, but instead we overloadedIKeyto behave like a hypotheticalIKeyLike, andIKeyRefnow inherits this double duty.Therefore, we now make the
IKeyRefimplementation ofAliasbehave like aIKeyLikeRef, and satisfy the contract using its own fields.Closes #35543
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license