Skip to content

feat(batch): ec2 Managed Compute Environment support default instance classes, deprecate useOptimalInstanceClasses#35537

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
phuhung273:batch-default-instance-classes
Oct 10, 2025
Merged

feat(batch): ec2 Managed Compute Environment support default instance classes, deprecate useOptimalInstanceClasses#35537
mergify[bot] merged 1 commit intoaws:mainfrom
phuhung273:batch-default-instance-classes

Conversation

@phuhung273
Copy link
Copy Markdown
Contributor

@phuhung273 phuhung273 commented Sep 20, 2025

Issue # (if applicable)

Closes #35515

Reason for this change

Description of changes

  • EC2 Managed Compute Environment support default instance classes
  • Deprecate useOptimalInstanceClasses

Description of how you validated changes

Unit + Integ

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Sep 20, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 20, 2025 10:40
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Sep 20, 2025
@phuhung273 phuhung273 force-pushed the batch-default-instance-classes branch from 2197b61 to 32cb2a6 Compare September 21, 2025 03:10
@github-actions github-actions bot mentioned this pull request Oct 1, 2025
Open
@Abogical Abogical self-assigned this Oct 10, 2025
Abogical
Abogical approved these changes Oct 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 10, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Oct 10, 2025
@Abogical
Copy link
Copy Markdown
Member

Abogical commented Oct 10, 2025

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codebuild-pr-build.yml without workflows permission

@Abogical
Copy link
Copy Markdown
Member

Abogical commented Oct 10, 2025

@Mergifyio rebase

@Abogical Abogical force-pushed the batch-default-instance-classes branch from 32cb2a6 to 394516b Compare October 10, 2025 14:23
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

rebase

✅ Branch has been successfully rebased

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 10, 2025
@mergify mergify bot merged commit 9d59dd8 into aws:main Oct 10, 2025
18 of 20 checks passed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Oct 10, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 10, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2025
@phuhung273 phuhung273 deleted the batch-default-instance-classes branch October 10, 2025 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Abogical Abogical Abogical approved these changes

Assignees

@Abogical Abogical

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-batch: Support new default instance classes for EC2 compute environment

2 participants

@phuhung273 @Abogical