fix(kinesisanalytics): deprecate using KinesisAnalyticsV2 from aws-kinesisanalytics, use aws-kinesisanalyticsv2 instead#35519
Merged
mergify[bot] merged 1 commit intomainfrom Sep 18, 2025
Conversation
aws-cdk-automation
previously requested changes
Sep 18, 2025
…odule, use aws-kinesisanalyticsv2 instead
a41497d to
f190a06
Compare
Contributor
Author
|
Added |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
approved these changes
Sep 18, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
Sometimes services introduces a
V2version of their APIs and CloudFormation resources.In the past we had thought it's a good idea if
KinesisAnalyticsV2constructs would just be included in the originalaws-kinesisanalyticsmodule. However since then we have come to a different view and think it's better to strictly follow what the services are doing. As of todayKinesisAnalyticsV2is the only service that got this treatment.We now want to clearly indicate that this is not supported and deprecate the usage from within the "V1" module.
Description of changes
Update the
spec2cdkpackage to allow services being deprecated.I've also changed the suffix handling to be explicit instead of computed when reading from a service map. Given that we only have that one module with multiple services, this seems prudent.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
All existing tests pass.
jsii-diffreports no issues. Test case added for codegen of deprecated service.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license