feat(spec2cdk): generate from<Resource>Arn and from<Resource><Prop> in every L1#35470
Merged
mergify[bot] merged 14 commits intomainfrom Sep 26, 2025
Merged
feat(spec2cdk): generate from<Resource>Arn and from<Resource><Prop> in every L1#35470mergify[bot] merged 14 commits intomainfrom
from<Resource>Arn and from<Resource><Prop> in every L1#35470mergify[bot] merged 14 commits intomainfrom
Conversation
aws-cdk-automation
previously requested changes
Sep 12, 2025
from<Resource>Arn in every L1from<Resource>Arn and from<Resource><Prop> in every L1
otaviomacedo
commented
Sep 18, 2025
| }); | ||
| }); | ||
|
|
||
| describe('L1 static factory methods', () => { |
Contributor
Author
There was a problem hiding this comment.
Choosing one representative to test that the generated methods actually return the right thing.
# Conflicts: # tools/@aws-cdk/spec2cdk/lib/cdk/resource-class.ts
rix0rrr
reviewed
Sep 23, 2025
- environmentFromArn - storing stackOfScope
# Conflicts: # packages/aws-cdk-lib/package.json # tools/@aws-cdk/spec2cdk/package.json # yarn.lock
rix0rrr
approved these changes
Sep 26, 2025
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 similar comment
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For every L1 resource, generate a static factory method called
from<Resource>Arn():as well as a
from<Prop>()(where<Prop>is the single field in the primary identifier):Note: If the primary identifier for a given resource type has more than one field, we skip the generation of the factory methods for the corresponding class.
TemplateStringParseris a new class with two static methods (inverses of each other):parse: matches a given ARN template with a concrete ARN string, and returns the values of each variable.interpolate: given an ARN template and a map of variables, returns a string with the variables replaced with their respective values.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license