feat(apigatewayv2): add disableSchemaValidation for Websocket api#35290
feat(apigatewayv2): add disableSchemaValidation for Websocket api#35290mergify[bot] merged 8 commits intoaws:mainfrom
Conversation
cdb39c2 to
45faf65
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
chore: execute integ tests
45faf65 to
bbb657c
Compare
mazyu36
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
Some minor comments.
| }); | ||
| ``` | ||
|
|
||
| For a detailed explanation of this function, including usage and examples, please refer to the [Generating ARN for Execute API](#generating-arn-for-execute-api) section under HTTP API. |
There was a problem hiding this comment.
This line refers to the arnForExecuteApiV2.
The example and explanation for arnForExecuteApiV2 are separated by the disableSchemaValidation sentences, which should be relocated to improve readability.
There was a problem hiding this comment.
Thanks!
Moved the disableSchemaValidation explanation to its own section to avoid interrupting the arnForExecuteApiV2 example and description flow.
|
|
||
| /** | ||
| * Avoid validating models when creating a deployment. | ||
| * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-resource-apigatewayv2-api.html |
There was a problem hiding this comment.
What is the purpose of adding this link?
It seems that this link is not specific to the adding property.
There was a problem hiding this comment.
Thanks!
I misunderstood the condition for when links are necessary, so I removed the redundant link.
…lidation addition.
leonmk-aws
left a comment
There was a problem hiding this comment.
Thank you for you contribution !
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
A property in L1 construct was not in L2 construct.
Description of changes
Add
disableSchemaValidationproperty toWebSocketApiPropsand set in theCfnApiconstructor.Describe any new or updated permissions being added
Description of how you validated changes
Added both unit and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license