feat(events): add support for Event Bus Logging Configuration by duranbe · Pull Request #35201 · aws/aws-cdk

duranbe · 2025-08-10T20:47:33Z

Issue #35000

Reason for this change
Logging Configuration has been recently added to Event Bridge buses and is supported in L1 construct but not L2.
Relevant Cloudformation Template Doc : https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-properties-events-eventbus-logconfig.html
AWS Doc for Configuring Logs : https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-event-bus-logs.html#eb-event-logs-data

Description of changes

Creation of an Enum for IncludeDetail property

export enum IncludeDetail {
  /**
   * FULL: Include all details related to event itself and the request EventBridge sends to the target.
   * Detailed data can be useful for troubleshooting and debugging.
   */
  FULL = 'FULL',
  /**
   * NONE: Does not include any details.
   */
  NONE = 'NONE',
}

Creation of an Enum for Level property

export enum Level {
  /**
   * INFO: EventBridge sends any logs related to errors, as well as major steps performed during event processing
   */
  INFO = 'INFO',
  /**
   * ERROR: EventBridge sends any logs related to errors generated during event processing and target delivery.
   */
  ERROR = 'ERROR',
  /**
   * TRACE: EventBridge sends any logs generated during all steps in the event processing.
   */
  TRACE = 'TRACE',
  /**
   *  OFF: EventBridge does not send any logs. This is the default.
   */
  OFF = 'OFF',
}

Creation of an Interface for LogConfiguration, with both properties optional as stated in the doc

export interface LogConfig {
  /**
   * Whether EventBridge include detailed event information in the records it generates.
   * @default no details
   */
  readonly includeDetail?: IncludeDetail;
  /**
   * Logging level
   * @default OFF
   */
  readonly level?: Level;
}

Update L2 Construct and props with optional property Log Config

readonly logConfig?: LogConfig;

Description of how you validated changes

Unit and Integration Tests

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

duranbe · 2025-08-13T10:54:14Z

Im not really sure why security guardian failed?

duranbe · 2025-08-13T13:55:03Z

ah I figured out the issue -> the test was using an IAM root account as assumedBy so I created a role instead

duranbe · 2025-08-13T20:48:48Z

Ready for review! :)

packages/@aws-cdk-testing/framework-integ/test/aws-events/test/integ.eventbus.ts

mergify · 2025-08-26T08:30:19Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-08-26T08:32:02Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

duranbe · 2025-08-26T09:19:09Z

@Mergifyio requeue

mergify · 2025-08-26T09:19:16Z

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details

sender-permission >= write

duranbe · 2025-08-26T12:24:47Z

[2/4] Fetching packages...
error Error: https://registry.npmjs.org/fast-uri/-/fast-uri-3.0.6.tgz: Request failed "429 Too Many Requests"
    at ResponseError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:696:66)
    at new ResponseError (/usr/local/lib/node_modules/yarn/lib/cli.js:802:124)
    at Request.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:66750:16)
    at Request.emit (node:events:524:28)
    at module.exports.Request.onRequestResponse (/usr/local/lib/node_modules/yarn/lib/cli.js:142287:10)
    at ClientRequest.emit (node:events:524:28)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:702:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:118:17)
    at TLSSocket.socketOnData (node:_http_client:544:22)
    at TLSSocket.emit (node:events:524:28)
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

🫠🫠🫠

duranbe · 2025-08-26T12:25:54Z

I'm missing write permissions to requeue, if @rix0rrr or @pahud can check help

mergify · 2025-08-27T06:25:45Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

aws-cdk-automation · 2025-09-17T00:11:16Z

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

Resume work on the PR
OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

mergify · 2025-09-17T09:58:06Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-09-17T09:58:24Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

feat(events): add support for Event Bus Logging Configuration

fe4f965

aws-cdk-automation requested a review from a team August 10, 2025 20:47

github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Aug 10, 2025

aws-cdk-automation previously requested changes Aug 10, 2025

View reviewed changes

aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Aug 10, 2025

duranbe added 2 commits August 13, 2025 10:25

Merge branch 'main' into add-log-config

1af266f

Update integ test and snapshot

744581a

duranbe requested a review from aws-cdk-automation August 13, 2025 10:03

duranbe added 2 commits August 13, 2025 12:22

fix integ test by running them correctly

7ebf48e

update Readme

26794fc

aws-cdk-automation removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Aug 13, 2025

Merge branch 'main' into add-log-config

5339de2

duranbe added 4 commits August 13, 2025 13:08

fix: add imports to ts example code for Rosetta

aaea6d6

fix rosetta build error

273ae0a

Merge branch 'main' into add-log-config

4fd41dd

fix readme and integ test

22e31bf

duranbe added 3 commits August 13, 2025 15:56

Merge branch 'main' into add-log-config

a501477

fix readme

c951401

Merge branch 'main' into add-log-config

6b3d3ac

Merge branch 'main' into add-log-config

535b82e

rix0rrr previously requested changes Aug 19, 2025

View reviewed changes

packages/@aws-cdk-testing/framework-integ/test/aws-events/test/integ.eventbus.ts Show resolved Hide resolved

rix0rrr self-assigned this Aug 19, 2025

Merge branch 'main' into add-log-config

763527c

duranbe added 2 commits August 24, 2025 16:56

Merge branch 'main' into add-log-config

38237a7

Merge branch 'main' into add-log-config

6a6c733

rix0rrr approved these changes Aug 26, 2025

View reviewed changes

Merge branch 'main' into add-log-config

ba99f24

rix0rrr previously approved these changes Aug 27, 2025

View reviewed changes

Merge branch 'main' into add-log-config

e80b58d

Merge branch 'main' into add-log-config

72db3af

github-actions bot mentioned this pull request Sep 1, 2025

Monthly PR metrics report #35377

Closed

duranbe added 3 commits September 1, 2025 13:21

Merge branch 'main' into add-log-config

5bf9ae1

Merge branch 'main' into add-log-config

59916db

Merge branch 'main' into add-log-config

476b693

badmintoncryer mentioned this pull request Sep 11, 2025

feat(events): log configuration for an event bus #35462

Closed

1 task

Merge branch 'main' into add-log-config

5534c70

Merge branch 'main' into add-log-config

02e1330

duranbe requested a review from rix0rrr September 17, 2025 09:57

alvazjor approved these changes Sep 17, 2025

View reviewed changes

mergify bot merged commit 7ceaefb into aws:main Sep 17, 2025
22 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2025

duranbe deleted the add-log-config branch October 7, 2025 09:35

Conversation

duranbe commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue #35000

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

duranbe commented Aug 13, 2025

Uh oh!

duranbe commented Aug 13, 2025

Uh oh!

duranbe commented Aug 13, 2025

Uh oh!

Uh oh!

mergify bot commented Aug 26, 2025

Uh oh!

mergify bot commented Aug 26, 2025

The merge conditions cannot be satisfied due to failing checks:

Uh oh!

duranbe commented Aug 26, 2025

Uh oh!

mergify bot commented Aug 26, 2025

❌ Command disallowed due to command restrictions in the Mergify configuration.

Uh oh!

duranbe commented Aug 26, 2025

Uh oh!

duranbe commented Aug 26, 2025

Uh oh!

mergify bot commented Aug 27, 2025

Uh oh!

aws-cdk-automation commented Sep 17, 2025

Uh oh!

mergify bot commented Sep 17, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

duranbe commented Aug 10, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading