feat(kinesisfirehose): support custom time zone settings for S3 destination#34738
feat(kinesisfirehose): support custom time zone settings for S3 destination#34738mergify[bot] merged 4 commits intoaws:mainfrom
Conversation
ozelalisen
left a comment
There was a problem hiding this comment.
Could you resolve merge conflicts? PR is looking good
|
This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@ozelalisen |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34737.
Reason for this change
Amazon Data Firehose supports to configure the time zone of timestamps in S3 object prefix.
For details, see https://docs.aws.amazon.com/firehose/latest/dev/s3-prefixes.html#timestamp-namespace
Description of changes
Added the
timeZoneprop toS3BucketPropsinterface to setExtendedS3Destination.CustomTimeZone.Note: Not in
CommonPropssince onlyExtendedS3DestinationConfigurationsupports time zone.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Unit test and integ test.
I've confirmed setting timeZone reflects to Firehose's console.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license