Skip to content

feat(apigatewayv2): add stage variables support for HTTP and WebSocket API#34548

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
gasolima:add-stage-variables
Jul 4, 2025
Merged

feat(apigatewayv2): add stage variables support for HTTP and WebSocket API#34548
mergify[bot] merged 3 commits intoaws:mainfrom
gasolima:add-stage-variables

Conversation

@gasolima
Copy link
Copy Markdown
Contributor

@gasolima gasolima commented May 24, 2025 •
edited
Loading

Issue

Closes #11818 .

Reason for this change

To support stage variables to HttpApi & WebSocketApi.

Description of changes

Add stageVariables property to WebSocketStage & HttpStage.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

  • Add a unit test
  • Tested it manually by creating stack to use the new props and check the CF template & UI

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 24, 2025 19:32
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels May 24, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 24, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes May 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label May 26, 2025
rix0rrr
rix0rrr approved these changes May 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with this change!

Added pr/do-not-merge so you can have some more talks about the details, feel free to remove the label whenever you're ready to merge.

@github-actions github-actions bot mentioned this pull request Jun 1, 2025
Closed
@aemada-aws aemada-aws self-assigned this Jun 18, 2025
@gasolima gasolima force-pushed the add-stage-variables branch 3 times, most recently from c56365d to b48dccc Compare July 3, 2025 08:03
@gasolima gasolima force-pushed the add-stage-variables branch from b48dccc to 4170377 Compare July 3, 2025 08:05
@gasolima gasolima removed the pr/do-not-merge This PR should not be merged at this time. label Jul 3, 2025
@gasolima gasolima added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 4, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 4, 2025 09:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 4, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1d737ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 965e055 into aws:main Jul 4, 2025
18 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 4, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@aemada-aws aemada-aws aemada-aws approved these changes

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

+1 more reviewer

@scorbiere scorbiere scorbiere left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@aemada-aws aemada-aws

Labels

contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(api-gateway-v2): Add stage variables to HttpApi Stage

7 participants

@gasolima @aws-cdk-automation @rix0rrr @scorbiere @aemada-aws @vishaalmehrishi @Abogical