-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
@aws-cdk/coreRelated to core CDK functionalityRelated to core CDK functionalitycliIssues related to the CDK CLIIssues related to the CDK CLIeffort/mediumMedium work item – several days of effortMedium work item – several days of effortp2
Description
CliIoHost exists today as a singleton pattern. However this creates an issue if someone wanted to do parrallel executions of the Cli i.e.
Promise.all([
myToolkit.deploy(appA),
myToolkit.deploy(appB)
]);or if someone wanted to maintain multiple distinct copies of the tookit
const myAwesomeToolkitA = new Toolkit({
ioHost: myCustomIoHost()
})
const myAwesomeToolkitB = new Toolkit({
ioHost: myOtherCustomIoHost()
})This is done if:
- The singleton pattern is gone
- Anywhere the the Cli was calling a log function i.e.
info()is now changed to aIoHost.notify(). - Log functions should return a formatted IoMessage, i.e.
IoHost.notify(info('my message'))or some equivalent functionality
Singleton Implementation Pr:
#32708
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
@aws-cdk/coreRelated to core CDK functionalityRelated to core CDK functionalitycliIssues related to the CDK CLIIssues related to the CDK CLIeffort/mediumMedium work item – several days of effortMedium work item – several days of effortp2