feat: set log retention of all CDK-vended custom resources with CustomResourceConfig by awslukeguan · Pull Request #31041 · aws/aws-cdk

awslukeguan · 2024-08-06T17:01:20Z

Reason for this change

CDK vended custom resources may or may not have Cloudwatch logGroup set with a retention period.
Modify all CDK-vended custom resources with CustomResourceConfig and to modify retention period with addLogRetentionLifetime method.

CustomResourceConfig.of(app).addLogRetentionLifetime(logs.RetentionDays.TEN_YEARS);

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

comcalvi

This is a great start! I have a few comments though 🙂

Please add an integration test (in @aws-cdk-testing), move this code to aws-cdk-lib/custom-resources and update that module's README to tell users how to use the new feature.

packages/@aws-cdk/custom-resource-handlers/lib/custom-resources-framework/classes.ts

packages/aws-cdk-lib/custom-resource-config/custom-resource-config.ts

packages/aws-cdk-lib/custom-resource-config/test/custom-resource-config.test.ts

comcalvi · 2024-08-08T17:32:03Z

Also please update the title to be a feat, since this is a feature. The feature should describe the new feature you're adding; for example, "Set log retention of all CDK-vended custom resources with CustomResourceConfig"

Pull request has been modified.

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

packages/aws-cdk-lib/custom-resources/lib/custom-resource-config/custom-resource-config.ts

...ages/aws-cdk-lib/custom-resources/test/custom-resource-config/custom-resource-config.test.ts

comcalvi · 2024-08-16T16:24:38Z

This is very close to merging 🙂 we're almost there!

Pull request has been modified.

comcalvi

Nice work! 🎉

Pull request has been modified.

aws-cdk-automation · 2024-08-16T20:57:03Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 50125b3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-08-16T21:37:49Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-08-16T21:38:10Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

Added method addMetadata for singleton lambda construct tree

e2c647e

github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Aug 6, 2024

aws-cdk-automation requested a review from a team August 6, 2024 17:01

aws-cdk-automation previously requested changes Aug 6, 2024

View reviewed changes

awslukeguan changed the title ~~chore: Added method addMetadata for singleton lambda construct tree~~ chore: added method addMetadata for singleton lambda construct tree Aug 6, 2024

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 6, 2024

comcalvi self-requested a review August 6, 2024 18:09

comcalvi self-assigned this Aug 6, 2024

awslukeguan added 6 commits August 7, 2024 13:28

Merge branch 'aws:main' into addmetadata

36efff7

chore: added metadata option to singleton lambda

ca5feda

chore: updated classes.ts to build constructor with statementProps

717e058

chore: added internal _logRetention

8dc2d4e

Merge branch 'aws:main' into addmetadata

eedbfdc

chore: added custom-resource-config aspects and tests

24dada7

comcalvi previously requested changes Aug 8, 2024

View reviewed changes

Merge branch 'aws:main' into addmetadata

f977361

Merge branch 'aws:main' into addmetadata

0994e1c

awslukeguan changed the title ~~chore: added method addMetadata for singleton lambda construct tree~~ feat: set log retention of all CDK-vended custom resources with CustomResourceConfig Aug 9, 2024

aws-cdk-automation previously requested changes Aug 9, 2024

View reviewed changes

awslukeguan added 7 commits August 9, 2024 12:01

chore: updated classes.ts

f5fd4e8

chore: updated custom-resource-config.ts

74d4c7a

chore: updated custom-resource-config.test.ts

a5d0b95

chore: moving folder

33334b4

chore: updated integ test and README.md

ae825fb

chore: updated README.md

05e675a

chore: updated classes.ts

6fc81bd

awslukeguan added 10 commits August 15, 2024 12:07

Merge branch 'aws:main' into addmetadata

cf87123

update custom-resource-framework test due to modified classes.ts

07d0c4d

referencing variables from config.ts

976077d

combining import on one line

1b8b066

adding comments to explain

dae936e

updating integ snapshots

8d9e4fa

update README.md

ee54708

update README.md

26e3042

update README.md

e3fadc5

Merge branch 'aws:main' into addmetadata

3bd7295

comcalvi previously requested changes Aug 16, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 16, 2024

updated test structure and minor changes

5bc66a1

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 16, 2024

updated tests

cb1b70e

comcalvi previously approved these changes Aug 16, 2024

View reviewed changes

updated tests

fbadca8

comcalvi previously approved these changes Aug 16, 2024

View reviewed changes

updated tests

50125b3

comcalvi approved these changes Aug 16, 2024

View reviewed changes

mergify bot merged commit f2babd9 into aws:main Aug 16, 2024

github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 16, 2024

Conversation

awslukeguan commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reason for this change

Checklist

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

comcalvi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

comcalvi commented Aug 8, 2024

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

comcalvi commented Aug 16, 2024

Uh oh!

comcalvi left a comment

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation commented Aug 16, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Aug 16, 2024

Uh oh!

github-actions bot commented Aug 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

awslukeguan commented Aug 6, 2024 •

edited

Loading