feat(events): add description property for eventBus#30935
feat(events): add description property for eventBus#30935mergify[bot] merged 6 commits intoaws:mainfrom
description property for eventBus#30935Conversation
|
Comments on closed issues and PRs are hard for our team to see. |
go-to-k
left a comment
There was a problem hiding this comment.
Nice, but I just made a few comments.
| // WHEN | ||
| new EventBus(stack, 'Bus', { | ||
| eventBusName: 'myEventBus', | ||
| description: 'myEventBus', |
There was a problem hiding this comment.
Could you separate it and create a new test because the name of this test is 'named event bus'?
| }).toThrow(/'eventSourceName' must satisfy: /); | ||
| }); | ||
|
|
||
| test('throw error when description is too long', () => { |
There was a problem hiding this comment.
Usually this test name is fine, but in this file, many tests for other errors have names of the following form: 'event bus xx cannot ...', so could you please match them?
|
@go-to-k |
Leo10Gama
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just left one comment regarding the token check.
Leo10Gama
left a comment
There was a problem hiding this comment.
Giving it a second look-over, everything seems fine! Just one minor nit about the phrasing of the docstring.
Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Committing the suggested change to the wording and approving per @Leo10Gama's review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
The change introduces the
descriptionproperty to theEventBusDescription of changes
descriptionproperty forEventBusProps, which was missing in the L2 construct.Description of how you validated changes
I Added a unit test for eventBus and added the
descriptionproperty in the integration tests.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license