Skip to content

fix(cognito-identitypool-alpha): validation error if provided id is a token#30882

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
Tietew:cognito-idp-allow-token
Aug 15, 2024
Merged

fix(cognito-identitypool-alpha): validation error if provided id is a token#30882
mergify[bot] merged 3 commits intoaws:mainfrom
Tietew:cognito-idp-allow-token

Conversation

@Tietew
Copy link
Copy Markdown
Contributor

@Tietew Tietew commented Jul 18, 2024

Issue # (if applicable)

Closes #29780.
Closes #28184.

Description of changes

Skips validations if provided id is an unresolved token.

Description of how you validated changes

Added unit tests not to throw errors even if the resolved value is incorrect.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Jul 18, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 18, 2024 06:11
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Tietew
Copy link
Copy Markdown
Contributor Author

Tietew commented Jul 18, 2024

Exemption Request
This PR fixes validations only.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 18, 2024
Copy link
Copy Markdown
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 31, 2024
@xazhao xazhao added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Jul 31, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 31, 2024 23:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Tietew
Copy link
Copy Markdown
Contributor Author

Tietew commented Aug 1, 2024

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 1, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review August 1, 2024 06:19

Pull request has been modified.

@github-actions github-actions bot added effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort labels Aug 1, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 1, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 14, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0bc55e7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ad1b797 into aws:main Aug 15, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2024
@Tietew Tietew deleted the cognito-idp-allow-token branch August 15, 2024 01:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

5 participants