Skip to content

feat(dynamodb): adding on-demand-throughput to table#30725

Merged
mergify[bot] merged 8 commits intoaws:mainfrom
LeeroyHannigan:max-throughput-lhnng
Aug 8, 2024
Merged

feat(dynamodb): adding on-demand-throughput to table#30725
mergify[bot] merged 8 commits intoaws:mainfrom
LeeroyHannigan:max-throughput-lhnng

Conversation

@LeeroyHannigan
Copy link
Copy Markdown
Contributor

@LeeroyHannigan LeeroyHannigan commented Jul 1, 2024

Issue # (if applicable)

Closes #30091

Reason for this change

New DynamoDB feature that was just released

Description of changes

Added maxReadRequestUnits and maxWriteRequestUnits for PAY_PER_REQUEST tables

Description of how you validated changes

Tests on integ.dynamodb.ondemand.ts

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 1, 2024 16:29
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jul 1, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 2, 2024
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Closed
@shikha372 shikha372 self-assigned this Jul 24, 2024
@shikha372
Copy link
Copy Markdown
Contributor

shikha372 commented Jul 24, 2024

Thank you for submitting this pull request, will take a look at the implementation for any updates this week

shikha372
shikha372 reviewed Jul 26, 2024
View reviewed changes
shikha372
shikha372 reviewed Jul 26, 2024
View reviewed changes
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Closed
@shikha372
Copy link
Copy Markdown
Contributor

shikha372 commented Aug 7, 2024 •
edited
Loading

Thank you @LeeroyHannigan for the pull request, changes look okay to me but I see no unit tests added for this new feature, can we cover that as well?

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 8, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 8, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d3b172e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d5a19bb into aws:main Aug 8, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 8, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@shikha372 shikha372 shikha372 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shikha372 shikha372

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-dynamodb: OnDemandThroughput configuration

3 participants

@LeeroyHannigan @shikha372 @aws-cdk-automation