Skip to content

feat(sagemaker): network isolation for a model#30657

Merged
mergify[bot] merged 14 commits intoaws:mainfrom
badmintoncryer:enableNetworkIsolation
Aug 13, 2024
Merged

feat(sagemaker): network isolation for a model#30657
mergify[bot] merged 14 commits intoaws:mainfrom
badmintoncryer:enableNetworkIsolation

Conversation

@badmintoncryer
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer commented Jun 25, 2024

Issue # (if applicable)

None

Reason for this change

SageMaker model supports for the network isolation function. But Model construct does not support this.

Description of changes

Add networkIsolation to ModelProps

const model = new sagemaker.Model(this, 'ContainerModel', {
  containers: [
    {
      image,
      modelData,
    }
  ],
  networkIsolation: true, // Added
});

Description of how you validated changes

Added both unit and integ tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 25, 2024 03:42
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels Jun 25, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024
msambol
msambol reviewed Jun 28, 2024
View reviewed changes
msambol
msambol approved these changes Jun 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@msambol msambol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise LGTM.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 28, 2024
@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Jun 29, 2024

@msambol Thanks always! I've fixed comments.

This was referenced Jul 1, 2024
Closed
Closed
msambol
msambol reviewed Jul 1, 2024
View reviewed changes
packages/@aws-cdk/aws-sagemaker-alpha/lib/model.ts Outdated
readonly allowAllOutbound?: boolean;

/**
* Whether to isolate the model container.
Copy link
Copy Markdown
Contributor

@msambol msambol Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be more descriptive. Maybe combine this with the sentence below.

Copy link
Copy Markdown
Contributor Author

@badmintoncryer badmintoncryer Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have combined the sentences below. If you have any better suggestions, please let me know!

msambol
msambol reviewed Jul 1, 2024
View reviewed changes
msambol
msambol reviewed Jul 1, 2024
View reviewed changes
packages/@aws-cdk/aws-sagemaker-alpha/lib/model.ts Outdated
readonly allowAllOutbound?: boolean;

/**
* Whether to isolate to enable network isolation for the model container.
Copy link
Copy Markdown
Contributor

@msambol msambol Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I messed up, sorry: Whether to enable network isolation for the model container.

msambol
msambol approved these changes Jul 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@msambol msambol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shikha372 shikha372 self-assigned this Aug 12, 2024
shikha372
shikha372 previously approved these changes Aug 12, 2024
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 12, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Aug 13, 2024

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 13, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/issue-regression-labeler.yml without workflows permission

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Aug 13, 2024

@shikha372 Thank you for your approval. Could you please resolve the mergify job problem?

@mergify mergify bot dismissed shikha372’s stale review August 13, 2024 17:44

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 13, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 13, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e0857ba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f1af7fc into aws:main Aug 13, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 13, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 13, 2024
@badmintoncryer badmintoncryer deleted the enableNetworkIsolation branch August 14, 2024 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@msambol msambol msambol approved these changes

@shikha372 shikha372 shikha372 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shikha372 shikha372

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@badmintoncryer @aws-cdk-automation @msambol @shikha372