feat(ec2): security group lookup via filters#30625
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Clarification Request Does this feature need a new integration test? If so, I'm struggling to figure out how to write one for a lookup like this. |
|
Exemption Request |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
msambol
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding the additional coverage in the integration test.
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
All tests passed. Adding the cli tested label. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
|
We are now using an externally published version of cloud assembly schema. This needs to be reverted as it conflicts with that. |
Issue # (if applicable)
Closes #30331.
Reason for this change
This will improve the security group lookup functionality for importing existing security groups into a CDK stack.
Description of changes
I added the ability to lookup existing security groups via more filters. Filters are supported by the DescribeSecurityGroups API, and using these filters can be immensely useful for looking up existing security groups, especially if your account or organization follows predictable rules regarding things like security group tags.
Description of how you validated changes
I added unit tests similar to the ones that test the normal lookup by ID or name.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license