Skip to content

secretsmanager: allow to specify semanticVersion in semanticVersionForPartition #30200

@pahud

Description

@pahud

Describe the bug

semanticVersionForPartition has pinned version which does not allow users to specify the version number.

At this moment, 1.1.212 for aws-cn comes with deprecated python runtime and there's no workaroud for that.

public semanticVersionForPartition(partition: string) {
if (partition === 'aws') {
return this.semanticVersion;
} else if (partition === 'aws-cn') {
return '1.1.212';
} else if (partition === 'aws-us-gov') {
return '1.1.93';
} else {
throw new Error(`unsupported partition: ${partition}`);
}
}
}

Expected Behavior

We should allow user to specify the version number.

Current Behavior

User can't specify version number and requires a PR to bump the version.

Reproduction Steps

similar to #28696

Possible Solution

Additional Information/Context

No response

CDK CLI Version

v2.141.0

Framework Version

No response

Node.js Version

all

OS

all

Language

TypeScript

Language Version

No response

Other information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    @aws-cdk/aws-secretsmanagerRelated to AWS Secrets ManagerbugThis issue is a bug.effort/mediumMedium work item – several days of effortp3

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions