feat(codecommit): kmsKey for repository#29988
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
This PR title seems to be about a codebuild module, but it would be a codecommit.
Also, since this PR is not a change in processing but the addition of a new property, the PR title could be simpler: such as feat(codecommit): `kmsKey` for repository.
packages/@aws-cdk-testing/framework-integ/test/aws-codecommit/test/integ.repository-kms-key.ts
Outdated
Show resolved
Hide resolved
kmsKey for repository
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
|
@go-to-k |
go-to-k
left a comment
There was a problem hiding this comment.
Thanks for the changes. LGTM.
That was a tough to the change of the integ test... :)
|
@go-to-k Thank you very much! I got stuck with Git when trying to change file names from lowercase to uppercase.....😓 |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@mergify update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #.
Reason for this change
Cloudformation supports for using customer managed kms key to encrypt data in codecommit repository but CDK doesn't support it.
Description of changes
Add
kmsKeyproperty toRepositoryProps.Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license