Skip to content

fix(CLI): bootstrap shows no hotswap changes when there are no changes#29877

Merged
mergify[bot] merged 4 commits intomainfrom
comcalvi/bootstrap-hotswap
Apr 19, 2024
Merged

fix(CLI): bootstrap shows no hotswap changes when there are no changes#29877
mergify[bot] merged 4 commits intomainfrom
comcalvi/bootstrap-hotswap

Conversation

@comcalvi
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi commented Apr 17, 2024 •
edited
Loading

Issue # (if applicable)

Closes #25736.

Reason for this change

The bootstrap calls deployStack without specifying hotswap, and deployStack does not correctly default the hotswap mode to FULL_DEPLOYMENT.

Description of changes

Make deployStack correctly default hotswapMode to FULL_DEPLOYMENT.

Description of how you validated changes

Manual testing. Before this change:

 ✨ hotswap deployment skipped - no changes were detected (use --force to override)

 ✅  Environment aws://123456789012/us-east-1 bootstrapped (no changes).

After:

 ✅  Environment aws://123456789012/us-east-1 bootstrapped (no changes).

Unit tests not added because we don't have any unit tests for bootstrap and this is cosmetic.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 17, 2024 23:17
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Apr 17, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 17, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 17, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@comcalvi comcalvi force-pushed the comcalvi/bootstrap-hotswap branch from 623c8c0 to 19a4dbd Compare April 17, 2024 23:20
@comcalvi comcalvi added the pr-linter/exempt-test The PR linter will not require test changes label Apr 17, 2024
piradeepk
piradeepk approved these changes Apr 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @comcalvi! Lgtm 🚀

@comcalvi comcalvi added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested labels Apr 17, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 18, 2024 22:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot temporarily deployed to test-pipeline April 18, 2024 23:40 Inactive
@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

TheRealAmazonKendra commented Apr 19, 2024

@Mergifyio unqueue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 19, 2024

unqueue

✅ The pull request has been removed from the queue default

@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

TheRealAmazonKendra commented Apr 19, 2024

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 19, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 19, 2024

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 19, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 19, 2024

update

✅ Branch has been successfully updated

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 19, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c82630f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2126ee5 into main Apr 19, 2024
@mergify mergify bot deleted the comcalvi/bootstrap-hotswap branch April 19, 2024 21:00
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
This was referenced May 23, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request May 30, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this pull request Jun 13, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 14, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 20, 2024
Closed
@NOUIY NOUIY mentioned this pull request Jun 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 21, 2024
Open
This was referenced Jun 22, 2024
Open
Open
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 25, 2024

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@piradeepk piradeepk piradeepk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cdk bootstrap prints "hotswap deployment skipped" when there is no diff

4 participants

@comcalvi @TheRealAmazonKendra @aws-cdk-automation @piradeepk