Exemption Request - unit tests added

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 4ff9cf1
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

I reviewed the code and I don't think it works when the function arn is an unresolved token (i.e. passed as a parameter to the CloudFormation stack). See my comment and suggestions here

I think this change is backwards incompatible - it broke our stack.

Previously, if you passed a function arn with a version, the getFunctionArn would retain that version. It no longer does - and this caused an outage for us (by causing an APIG authorizer to point to the "root" lambda function instead of a specific alias - where it didn't haver permissions)

Sorry to hear the change caused an outage. My issue still isn't fixed with the change (see also my comment above, in which I also suggested not to change Function.fromFunctionArn, but instead fix Version.fromVersionArn).

This still generates an invalid stack:

const DemoClientVersionArn = new cdk.CfnParameter(this, 'DemoClientVersionArn');

const demoClientVersion = lambda.Version.fromVersionArn(this, 'DemoClientVersion', DemoClientVersionArn.valueAsString);

const demoClientCurrentAlias = new lambda.Alias(this, 'DemoClientCurrentAlias', {
    aliasName: 'current',
    version: demoClientVersion,
});

// The function url resource created by the CDK causes a CloudFormation deployment error
// because the version qualifier is still part of the functionArn of the lambda.Function
// created by lambda.Version.fromVersionArn
const demoClientFunctionUrl = new lambda.FunctionUrl(this, 'DemoClientFunctionUrl', {
    authType: lambda.FunctionUrlAuthType.AWS_IAM,
    invokeMode: lambda.InvokeMode.RESPONSE_STREAM,
    function: demoClientCurrentAlias,
});

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.