fix(eks): incorrect nodegroupName(under feature flag) by pahud · Pull Request #29794 · aws/aws-cdk

pahud · 2024-04-11T15:42:44Z

Issue # (if applicable)

As #22910 and #25278 were closed for staleness. I am opening a new PR to fix #22442.

To avoid breaking change, this PR introduces a new feature flag for the bug fix.

The Code for verification

import {
  App, Stack,
  aws_eks as eks,
  aws_ec2 as ec2,
  CfnOutput, cx_api,
} from 'aws-cdk-lib';

const app = new App();
const env = { region: process.env.CDK_DEFAULT_REGION, account: process.env.CDK_DEFAULT_ACCOUNT };
const stack = new Stack(app, 'my-test-stack2', { env });

stack.node.setContext(cx_api.EKS_NODEGROUP_NAME, true);

const vpc = ec2.Vpc.fromLookup(stack, 'Vpc', { isDefault: true });

const cluster = new eks.Cluster(stack, 'Cluster', {
  vpc,
  version: eks.KubernetesVersion.V1_29,
  defaultCapacity: 0,
});

const ng1 = new eks.Nodegroup(stack, 'ng-1', {
  cluster,
});

const ng2 = cluster.addNodegroupCapacity('ng-2', {
  nodegroupName: 'custom-name',
});

new CfnOutput(stack, 'ng1-name', { value: ng1.nodegroupName });
new CfnOutput(stack, 'ng2-name', { value: ng2.nodegroupName });

The output is like

Outputs:
my-test-stack2.ng1name = ng19F1EA947-sSziNMzPVkik
my-test-stack2.ng2name = custom-name

Console:

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

…x-eks-ng

GavinZZ

LGTM

mergify · 2024-04-18T17:57:48Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-04-18T18:01:43Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TheRealAmazonKendra · 2024-04-18T23:46:16Z

@Mergifyio update

mergify · 2024-04-18T23:46:27Z

update

☑️ Nothing to do

Details

queue-position=-1 [📌 update requirement]
#commits-behind>0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]

TheRealAmazonKendra · 2024-04-18T23:47:02Z

update

☑️ Nothing to do

That's... not true.

GavinZZ · 2024-04-19T20:02:04Z

@mergify update

mergify · 2024-04-19T20:02:33Z

update

✅ Branch has been successfully updated

mergify · 2024-04-19T20:31:43Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-04-19T23:03:37Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-04-19T23:51:51Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 32a0090
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-04-19T23:52:13Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-07-25T21:16:35Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

fix nodegroupName

030a012

github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Apr 11, 2024

aws-cdk-automation requested a review from a team April 11, 2024 15:42

mergify bot added the contribution/core This is a PR that came from AWS. label Apr 11, 2024

aws-cdk-automation previously requested changes Apr 11, 2024

View reviewed changes

update snap

d956ff9

minor fix

519e317

pahud marked this pull request as ready for review April 11, 2024 16:34

pahud added 6 commits April 11, 2024 17:23

V2NEXT

4ba9291

update cxapi README

4a4194d

update

827b31b

Merge branch 'main' into fix-eks-ng

e60c5a0

update snap

a43eba6

update snap

ff2c8eb

aws-cdk-automation previously requested changes Apr 11, 2024

View reviewed changes

update snap

bd8b79d

pahud added 4 commits April 12, 2024 02:58

update

db4819b

Merge branch 'main' into fix-eks-ng

8222f1f

V2NEXT

046836f

Merge branch 'fix-eks-ng' of https://github.com/pahud/aws-cdk into fi…

a895596

…x-eks-ng

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 12, 2024

github-actions bot mentioned this pull request Apr 15, 2024

Weekly PR metrics report #29829

Closed

GavinZZ approved these changes Apr 18, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 18, 2024

Merge branch 'main' into fix-eks-ng

f63e34b

TheRealAmazonKendra approved these changes Apr 18, 2024

View reviewed changes

Merge branch 'main' into fix-eks-ng

c05330b

Merge branch 'main' into fix-eks-ng

93a6aea

Merge branch 'main' into fix-eks-ng

32a0090

mergify bot merged commit 8bb8c55 into aws:main Apr 19, 2024

github-actions bot mentioned this pull request May 1, 2024

Monthly PR metrics report #30026

Closed

This was referenced May 23, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#98

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#99

Open

NOUIY mentioned this pull request May 30, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#101

Open

NOUIY mentioned this pull request Jun 7, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#102

Open

niravparikh05 mentioned this pull request Jun 13, 2024

[Snyk] Upgrade aws-cdk from 2.65.0 to 2.142.1 paralus/eks-blueprints-addon#3

Open

NOUIY mentioned this pull request Jun 14, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#103

Open

snyk-io bot mentioned this pull request Jun 20, 2024

[Snyk] Upgrade aws-cdk-lib from 2.138.0 to 2.143.1 Opetushallitus/heratepalvelu#280

Closed

NOUIY mentioned this pull request Jun 20, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#104

Open

snyk-io bot mentioned this pull request Jun 21, 2024

[Snyk] Upgrade aws-cdk-lib from 2.139.0 to 2.143.1 Opetushallitus/ovara#36

Open

This was referenced Jun 22, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#105

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#106

Open

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Conversation

pahud commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

The Code for verification

Checklist

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

GavinZZ left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Apr 18, 2024

Uh oh!

mergify bot commented Apr 18, 2024

Uh oh!

TheRealAmazonKendra commented Apr 18, 2024

Uh oh!

mergify bot commented Apr 18, 2024

☑️ Nothing to do

Uh oh!

TheRealAmazonKendra commented Apr 18, 2024

☑️ Nothing to do

Uh oh!

GavinZZ commented Apr 19, 2024

Uh oh!

mergify bot commented Apr 19, 2024

✅ Branch has been successfully updated

Uh oh!

mergify bot commented Apr 19, 2024

Uh oh!

mergify bot commented Apr 19, 2024

Uh oh!

aws-cdk-automation commented Apr 19, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Apr 19, 2024

Uh oh!

aws-cdk-automation commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pahud commented Apr 11, 2024 •

edited

Loading