Skip to content

feat(ecs): support adding docker labels after container construction#29734

Merged
mergify[bot] merged 8 commits intoaws:mainfrom
msambol:29728
Apr 18, 2024
Merged

feat(ecs): support adding docker labels after container construction#29734
mergify[bot] merged 8 commits intoaws:mainfrom
msambol:29728

Conversation

@msambol
Copy link
Copy Markdown
Contributor

@msambol msambol commented Apr 5, 2024

Closes #29728.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 5, 2024 00:27
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Apr 5, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 5, 2024
lpizzinidev
lpizzinidev suggested changes Apr 6, 2024
View reviewed changes
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 6, 2024
@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Apr 6, 2024

@lpizzinidev Updated. Thank you as always!

lpizzinidev
lpizzinidev approved these changes Apr 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Please adjust the test case

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 6, 2024
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Closed
@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Apr 12, 2024

@scanlonp This one is ready though. 😄

@khushail khushail mentioned this pull request Apr 15, 2024
Closed
2 tasks
blimmer
blimmer approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@blimmer blimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!!

@godwingrs22 godwingrs22 self-requested a review April 17, 2024 17:44
@godwingrs22 godwingrs22 self-assigned this Apr 17, 2024
godwingrs22
godwingrs22 previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@godwingrs22 godwingrs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thank you @msambol for your contribution and @blimmer @lpizzinidev for the reviews.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 18, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@godwingrs22
Copy link
Copy Markdown
Contributor

godwingrs22 commented Apr 18, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@godwingrs22 godwingrs22 changed the title feat(ecs): support adding labels after container construction feat(ecs): support adding docker labels after container construction Apr 18, 2024
@godwingrs22
Copy link
Copy Markdown
Contributor

godwingrs22 commented Apr 18, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed godwingrs22’s stale review April 18, 2024 18:01

Pull request has been modified.

@godwingrs22
Copy link
Copy Markdown
Contributor

godwingrs22 commented Apr 18, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2024

update

☑️ Nothing to do

Details
  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@godwingrs22
Copy link
Copy Markdown
Contributor

godwingrs22 commented Apr 18, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2024

update

☑️ Nothing to do

Details
  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 18, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b9c0eec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8e215b3 into aws:main Apr 18, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
This was referenced May 23, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request May 30, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this pull request Jun 13, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 14, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 20, 2024
Closed
@NOUIY NOUIY mentioned this pull request Jun 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 21, 2024
Open
This was referenced Jun 22, 2024
Open
Open
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 25, 2024

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@blimmer blimmer blimmer approved these changes

@godwingrs22 godwingrs22 godwingrs22 approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@godwingrs22 godwingrs22

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(ecs): ContainerDefinition.addDockerLabel

5 participants

@msambol @godwingrs22 @aws-cdk-automation @blimmer @lpizzinidev