fix(pipelines): codeStar connection accepts nested repository#29631
fix(pipelines): codeStar connection accepts nested repository#29631mergify[bot] merged 8 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request: integrations test needs CodeStar connection but it is not feasible to create actual connection during the test. |
aaythapa
left a comment
There was a problem hiding this comment.
Thanks for making this change!
packages/aws-cdk-lib/pipelines/lib/codepipeline/codepipeline-source.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/pipelines/lib/codepipeline/codepipeline-source.ts
Outdated
Show resolved
Hide resolved
Not too familiar with CodeStar so I'll double check with the team to validate this before granting exemption. Doing a search through our integ tests I do see |
|
Hi again, chatted with the team and an integ test with a resource that deploys should be enough, don't need to make a request. You can use the template thats defined in the original issue as a starter. Also, you can look through this doc if you're unfamiliar with CDK integ tests. |
…ource.ts Co-authored-by: Aayush thapa <84202325+aaythapa@users.noreply.github.com>
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
I have added an integ test. Please correct me if the test does not make sense. |
I would like to cancel the request as an integ test has been added. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #27504
Reason for this change
The current validation of
repoStringin constructor ofCodeStarConnectionSourcedoes not support nested repository that can appear in GitLab.Description of changes
The validation is fixed to accept nested repository.
Description of how you validated changes
I added unit tests and confirmed all tests passed.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license