fix(ecs-patterns): integ test unable to create ECS service#29490
Merged
mergify[bot] merged 3 commits intoaws:mainfrom Mar 21, 2024
Merged
fix(ecs-patterns): integ test unable to create ECS service#29490mergify[bot] merged 3 commits intoaws:mainfrom
mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
…teg.alb-fargate-service-command-entry-point
Contributor
|
@wafuwafu13 Could you change the title to |
integ.alb-fargate-service-command-entry-point
Contributor
Author
|
@msambol |
msambol
approved these changes
Mar 20, 2024
Contributor
msambol
left a comment
There was a problem hiding this comment.
LGTM. Thank you, @wafuwafu13.
godwingrs22
reviewed
Mar 20, 2024
Comment on lines
+18
to
+20
| allowAllOutbound: true, | ||
| }); | ||
| securityGroup.addIngressRule(ec2.Peer.anyIpv4(), ec2.Port.tcpRange(32768, 65535)); |
Contributor
There was a problem hiding this comment.
Nit: Could we restrict the inbound rules to allow only specific container port and also to deny all outbound traffic (allowAllOutbound: false) as I don't think it will be required for this usecase.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
godwingrs22
approved these changes
Mar 21, 2024
Contributor
godwingrs22
left a comment
There was a problem hiding this comment.
LGTM. Thank you for contributing.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
jun1-t
pushed a commit
to jun1-t/aws-cdk
that referenced
this pull request
Mar 23, 2024
### Issue # (if applicable) part of aws#29186 (comment) same as aws#29333 ### Reason for this change CFN stack gets stuck after `yarn integ` because of not being able to create ECS service. ``` AWS::ECS::Service | CREATE_IN_PROGRESS ``` ``` $ aws ecs describe-tasks --cluster aws-ecs-integ-lb-fargate-cmd-entrypoint-xxx --tasks xxxxxxxxxxxxxxx | jq '.tasks[].stopCode' "EssentialContainerExited" ``` ### Description of changes Change `taskImageOptions` `image`, `command`, `entryPoint` and add security group. Ref: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/example_task_definitions.html#example_task_definition-webserver ### Description of how you validated changes Pass integration tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 task
ahammond
pushed a commit
to ahammond/aws-cdk
that referenced
this pull request
Mar 26, 2024
### Issue # (if applicable) part of aws#29186 (comment) same as aws#29333 ### Reason for this change CFN stack gets stuck after `yarn integ` because of not being able to create ECS service. ``` AWS::ECS::Service | CREATE_IN_PROGRESS ``` ``` $ aws ecs describe-tasks --cluster aws-ecs-integ-lb-fargate-cmd-entrypoint-xxx --tasks xxxxxxxxxxxxxxx | jq '.tasks[].stopCode' "EssentialContainerExited" ``` ### Description of changes Change `taskImageOptions` `image`, `command`, `entryPoint` and add security group. Ref: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/example_task_definitions.html#example_task_definition-webserver ### Description of how you validated changes Pass integration tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
part of #29186 (comment)
same as #29333
Reason for this change
CFN stack gets stuck after
yarn integbecause of not being able to create ECS service.Description of changes
Change
taskImageOptionsimage,command,entryPointand add security group.Ref: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/example_task_definitions.html#example_task_definition-webserver
Description of how you validated changes
Pass integration tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license