fix(elasticloadbalancingv2): allow alb slow start duration of 0 seconds#29445
fix(elasticloadbalancingv2): allow alb slow start duration of 0 seconds#29445mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption request: Unit test should be fine here for this fix. |
godwingrs22
left a comment
There was a problem hiding this comment.
left a minor comment.
| @@ -330,8 +330,9 @@ export class ApplicationTargetGroup extends TargetGroupBase implements IApplicat | |||
|
|
|||
| if (props) { | |||
| if (props.slowStart !== undefined) { | |||
There was a problem hiding this comment.
Wondering if we need to handle where slowStart is not specified/undefined, to explicity set slow_start.duration_seconds attribute as default 0. since I saw in the issue reported, it was mentioned if it is not specified, it deploys successfully but Target Group resource still has it enabled(if previously enabled).
There was a problem hiding this comment.
hmm.. I think if they want it disabled they should have to set it explicitly ? My concern is if we set to 0, it will cause changes with stacks that are already deployed.
There was a problem hiding this comment.
Yeah seems valid. This looks good to me.
|
@godwingrs22 Do you mind merging |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #29437.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license