Skip to content

feat(rds): proxy for mariadb#29412

Merged
mergify[bot] merged 5 commits intoaws:mainfrom
msambol:29402v2
Mar 14, 2024
Merged

feat(rds): proxy for mariadb#29412
mergify[bot] merged 5 commits intoaws:mainfrom
msambol:29402v2

Conversation

@msambol
Copy link
Copy Markdown
Contributor

@msambol msambol commented Mar 8, 2024 •
edited
Loading

MariaDB is grouped with MySQL, hence adding MYSQL as the engine family for MariaDB.

Screenshot 2024-03-08 at 12 02 36 PM

Closes #29402.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 8, 2024 18:04
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Mar 8, 2024
@msambol msambol changed the title 29402v2 feat(rds): enable proxy for mariadb Mar 8, 2024
@msambol msambol mentioned this pull request Mar 8, 2024
Closed
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 8, 2024
@msambol msambol changed the title feat(rds): enable proxy for mariadb feat(rds): proxy for mariadb Mar 8, 2024
lpizzinidev
lpizzinidev approved these changes Mar 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Just a suggestion on the documentation.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 9, 2024
@msambol @lpizzinidev
Update packages/aws-cdk-lib/aws-rds/README.md
473c6fa 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 12, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Mar 12, 2024

@Mergifyio refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 12, 2024

refresh

✅ Pull request refreshed

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Mar 13, 2024

@Mergifyio refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 13, 2024

refresh

✅ Pull request refreshed

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Mar 13, 2024

@Mergifyio refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 13, 2024

refresh

✅ Pull request refreshed

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Mar 14, 2024

@Mergifyio refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 14, 2024

refresh

✅ Pull request refreshed

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 14, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2eb0e07
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6fef789 into aws:main Mar 14, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol msambol deleted the 29402v2 branch March 14, 2024 15:01
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
This was referenced May 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@aaythapa aaythapa aaythapa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug This issue is a bug. effort/medium Medium work item – several days of effort p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rds: Add support for MariaDB RDS Proxy

4 participants

@msambol @aws-cdk-automation @lpizzinidev @aaythapa