fix(events-targets): ApiGateway events target should accept IRestApi#29397
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Apr 24, 2024
Merged
fix(events-targets): ApiGateway events target should accept IRestApi#29397mergify[bot] merged 2 commits intoaws:mainfrom
ApiGateway events target should accept IRestApi#29397mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
aws-cdk-automation
previously requested changes
Mar 7, 2024
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
ApiGateway events target should accept IRestApi
0cef0c6 to
f8f83f4
Compare
f8f83f4 to
1d21c33
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
1d21c33 to
e34274f
Compare
e34274f to
7afac66
Compare
msambol
reviewed
Mar 21, 2024
msambol
reviewed
Mar 21, 2024
...ws-cdk-testing/framework-integ/test/aws-events-targets/test/api-gateway/integ.api-gateway.ts
Outdated
Show resolved
Hide resolved
msambol
reviewed
Mar 21, 2024
...ws-cdk-testing/framework-integ/test/aws-events-targets/test/api-gateway/integ.api-gateway.ts
Outdated
Show resolved
Hide resolved
0194e06 to
c17243a
Compare
gracelu0
previously requested changes
Apr 16, 2024
5981dde to
4b1544d
Compare
4b1544d to
ae2bd23
Compare
gracelu0
approved these changes
Apr 23, 2024
Contributor
gracelu0
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced May 23, 2024
This was referenced Jun 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #16423.
Reason for this change
The CDK construct to set an APIGatway as the target for an EventBridge rule only accepted RestApi. It should instead accept the interface IRestApi.
Description of changes
This change was attempted once earlier, but the PR was closed.
Changed the
ApiGatewaytarget's constructor's first argument fromapi.RestApitoapi.IRestApi.To fix compatibility failures caused by the previous
restApibeing a public member of the class, I've followed the approach suggested here. Some other alternatives are suggested here.Description of how you validated changes
Added a unit test that creates a dummy
SpecRestApi. Also added an integ test that creates aSpecRestApifrom a dummy OpenAPI spec and creates a rule on the default event bus with the APIGateway as target. Nothing is executed in the integ test. The assertion only checks if the target is created using theListTargetsByRuleAPI.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license