feat(stepfunctions-tasks): start glue crawler#29016
Conversation
| /** | ||
| * Glue crawler name | ||
| */ | ||
| readonly crawlerName: string; |
There was a problem hiding this comment.
I considered a specification that receives CfnCfnCrawler instead of crawlerName. The crawler name can be obtained from CfnCrawler.ref.
Which would be preferable?
There was a problem hiding this comment.
I prefer the current implementation.
cea6199 to
8a81e41
Compare
lpizzinidev
left a comment
There was a problem hiding this comment.
Looks good to me 👍
Just a note on the documentation
|
@lpizzinidev Thank you for your review! |
GavinZZ
left a comment
There was a problem hiding this comment.
Thanks for the PR, the changes look good just have a nit comments on the documentation.
| /** | ||
| * Glue crawler name | ||
| */ | ||
| readonly crawlerName: string; |
There was a problem hiding this comment.
I prefer the current implementation.
| You can call the [`StartCrawler`](https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-crawler-crawling.html#aws-glue-api-crawler-crawling-StartCrawler) API from a `Task` state through AWS SDK service integrations. | ||
|
|
||
| ```ts | ||
| new tasks.GlueStartCrawlerRun(this, 'Task', { |
There was a problem hiding this comment.
nit: might be worth adding another example using the .ref syntax as well as you've mentioned.
There was a problem hiding this comment.
I've added additional example!
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
e12f1fa to
6661ee0
Compare
|
@GavinZZ Thank you for your review!! I've added an example to use |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@GavinZZ Thanks! Mergidy job seems to be failed. Could you please resolve it? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue
Closes #24188.
Reason for this change
AWS Step Functions supports the ability to start a Glue Crawler as a task within a state machine. However, this is not configurable.
Description of changes
I've implemented
GlueStartCrawlerRunclass in stepfunctions-tasks and we can create start crawler task easily:Description of how you validated changes
I've added both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license