feat(route53): weighted routing by badmintoncryer · Pull Request #28705 · aws/aws-cdk

badmintoncryer · 2024-01-13T19:23:12Z

In this PR, I have implemented support for weighted routing.
By passing the weight and setIdentifier parameters when registering a record, it is possible to perform weighted routing among records that share the same name and type.

new route53.ARecord(this, `WeightedRecord${index}`, {
        zone: hostedZone,
        recordName: 'www',
        weight: 20, // added
        setIdentifier: 'uniqueId', // added
        target: route53.RecordTarget.fromIpAddresses('1.2.3.4'),
      });

Closes #26753.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev

Thanks 👍
I left some comments on the implementation.

packages/aws-cdk-lib/aws-route53/lib/record-set.ts

packages/aws-cdk-lib/aws-route53/README.md

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

badmintoncryer · 2024-01-14T16:25:42Z

@lpizzinidev
Thank you for your review.
I've addressed the comments and would like to hear your thoughts on generating the setIdentifier!

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev

Thanks 👍
I left some notes for some final cleanup.

packages/aws-cdk-lib/aws-route53/lib/record-set.ts

packages/aws-cdk-lib/aws-route53/README.md

packages/aws-cdk-lib/aws-route53/lib/record-set.ts

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

badmintoncryer · 2024-01-16T17:59:50Z

@lpizzinidev
Thank you for your comments.
I have made a modification to prevent the setting of setIdentifier for simple routing.

lpizzinidev

Thanks 👍

packages/aws-cdk-lib/aws-route53/README.md

kaizencc

Love the review back and forth @lpizzinidev @badmintoncryer. Caught a few edge cases that are now synth-time checks :). This looks good to me :)

mergify · 2024-01-17T22:33:04Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-01-17T23:34:25Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 4ea237d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-01-17T23:34:46Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

badmintoncryer added 4 commits January 14, 2024 02:06

feat: add weight

a3ea34c

feat: add setIdentifier

8a6b60b

test: integ test

49cfc69

test: update integ test

011f86e

github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jan 13, 2024

aws-cdk-automation requested a review from a team January 13, 2024 19:23

badmintoncryer changed the title ~~feat(route53): Support for weighted routing~~ feat(route53): support for weighted routing Jan 13, 2024

aws-cdk-automation previously requested changes Jan 13, 2024

View reviewed changes

docs: update README

15d2167

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 13, 2024

lpizzinidev suggested changes Jan 14, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 14, 2024

badmintoncryer and others added 3 commits January 15, 2024 00:18

README.md を更新

97f6a96

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-route53/lib/record-set.ts

a8bd796

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

fix: addressing comments

abbfe77

badmintoncryer added 2 commits January 16, 2024 18:06

Merge branch 'main' into 26753-addWeight

37efd38

feat: auto generate setIdentifier

2fb16a0

aws-cdk-automation previously requested changes Jan 16, 2024

View reviewed changes

test: update integ testy

62d8c33

badmintoncryer added 3 commits January 16, 2024 20:52

docs: comment

c6e9345

refactor: configureSetIdentifier

5251caa

refactor: rename function

9d9bbec

badmintoncryer mentioned this pull request Jan 16, 2024

support routing policy setting for ARecord class #4391

Open

docs: update README

50bd9b1

lpizzinidev suggested changes Jan 16, 2024

View reviewed changes

badmintoncryer and others added 7 commits January 17, 2024 00:54

record-set.ts を更新

e406916

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

README.md を更新

044db5d

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

README.md を更新

b0c6f7d

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

feat: setIdentifier cannot specify in simple routing

7d2629d

docs: update readme

fa4c811

Merge branch 'main' into 26753-addWeight

77f5fcd

fix: unit test

10ee48c

lpizzinidev approved these changes Jan 17, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 17, 2024

badmintoncryer added 2 commits January 17, 2024 20:09

Merge branch 'main' into 26753-addWeight

2c6c4f3

Merge branch 'main' into 26753-addWeight

eeb5750

kaizencc changed the title ~~feat(route53): support for weighted routing~~ feat(route53): weighted routing Jan 17, 2024

kaizencc reviewed Jan 17, 2024

View reviewed changes

packages/aws-cdk-lib/aws-route53/README.md Outdated Show resolved Hide resolved

Update packages/aws-cdk-lib/aws-route53/README.md

dba7cd3

kaizencc approved these changes Jan 17, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 17, 2024

Merge branch 'main' into 26753-addWeight

4ea237d

mergify bot merged commit 4a0c24d into aws:main Jan 17, 2024

badmintoncryer deleted the 26753-addWeight branch January 18, 2024 03:19

github-actions bot mentioned this pull request Feb 1, 2024

Monthly PR metrics report - Jan 2024 #28952

Closed

Conversation

badmintoncryer commented Jan 13, 2024

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

lpizzinidev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

badmintoncryer commented Jan 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

lpizzinidev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

badmintoncryer commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lpizzinidev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kaizencc left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Jan 17, 2024

Uh oh!

aws-cdk-automation commented Jan 17, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jan 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

badmintoncryer commented Jan 14, 2024 •

edited

Loading

badmintoncryer commented Jan 16, 2024 •

edited

Loading