feat(neptune-alpha): engineVersion v1.3#28647
Merged
mergify[bot] merged 6 commits intoaws:mainfrom Jan 11, 2024
Merged
Conversation
aws-cdk-automation
previously requested changes
Jan 10, 2024
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
3ddbd24 to
ed2317c
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
a4d27c7 to
730068e
Compare
go-to-k
suggested changes
Jan 11, 2024
Contributor
go-to-k
left a comment
There was a problem hiding this comment.
Thanks for this PR. I made a few comments.
Comment on lines
+833
to
+853
|
|
||
| test('create v1.3 engine version cluster', () => { | ||
| // GIVEN | ||
| const stack = testStack(); | ||
| const vpc = new ec2.Vpc(stack, 'VPC'); | ||
|
|
||
| // WHEN | ||
| new DatabaseCluster(stack, 'Database', { | ||
| instances: 1, | ||
| vpc, | ||
| instanceType: InstanceType.R5_LARGE, | ||
| engineVersion: EngineVersion.V1_3_0_0, | ||
| }); | ||
|
|
||
| // THEN | ||
| Template.fromStack(stack).hasResourceProperties('AWS::Neptune::DBCluster', { | ||
| DBSubnetGroupName: { Ref: 'DatabaseSubnets3C9252C9' }, | ||
| VpcSecurityGroupIds: [{ 'Fn::GetAtt': ['DatabaseSecurityGroup5C91FDCB', 'GroupId'] }], | ||
| EngineVersion: '1.3.0.0', | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
It is good to add here.
Suggested change
| test('create v1.3 engine version cluster', () => { | |
| // GIVEN | |
| const stack = testStack(); | |
| const vpc = new ec2.Vpc(stack, 'VPC'); | |
| // WHEN | |
| new DatabaseCluster(stack, 'Database', { | |
| instances: 1, | |
| vpc, | |
| instanceType: InstanceType.R5_LARGE, | |
| engineVersion: EngineVersion.V1_3_0_0, | |
| }); | |
| // THEN | |
| Template.fromStack(stack).hasResourceProperties('AWS::Neptune::DBCluster', { | |
| DBSubnetGroupName: { Ref: 'DatabaseSubnets3C9252C9' }, | |
| VpcSecurityGroupIds: [{ 'Fn::GetAtt': ['DatabaseSecurityGroup5C91FDCB', 'GroupId'] }], | |
| EngineVersion: '1.3.0.0', | |
| }); | |
| }); |
Contributor
|
The PR title would be |
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
Contributor
Author
|
@go-to-k Thank you for your continuous reviews! I have completed the modifications. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kaizencc
approved these changes
Jan 11, 2024
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Feb 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for the v1.3 engine.
Closes #28648.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license