-
Notifications
You must be signed in to change notification settings - Fork 4.5k
core: cdk.json "qualifier" ignored #28249
Copy link
Copy link
Closed
Labels
@aws-cdk/coreRelated to core CDK functionalityRelated to core CDK functionalitybugThis issue is a bug.This issue is a bug.effort/mediumMedium work item – several days of effortMedium work item – several days of effortneeds-reviewp1package/toolsRelated to AWS CDK Tools or CLIRelated to AWS CDK Tools or CLI
Description
Describe the bug
Setting qualifier attribute in cdk.json appears to not have any impact on running cdk bootstrap as it continues to use the default qualifier.
Expected Behavior
Setting the qualifier attribute in cdk.json should behave the same as running cdk bootstrap --qualifier <QUALIFIER_VALUE>.
Current Behavior
Running cdk bootstrap does not inherit the qualifier value stored in cdk.json
Reproduction Steps
Add a qualifier value to cdk.json:
{
"app": "npx ts-node --prefer-ts-exts bin/app.ts",
"versionReporting": false,
"watch": {
"include": [
"**"
],
"exclude": [
"README.md",
"cdk*.json",
"**/*.d.ts",
"**/*.js",
"tsconfig.json",
"package*.json",
"yarn.lock",
"node_modules",
"test"
]
},
"context": {
"@aws-cdk/core:bootstrapQualifier": "sample-app",
"@aws-cdk/aws-apigateway:usagePlanKeyOrderInsensitiveId": true,
"@aws-cdk/core:stackRelativeExports": true,
"@aws-cdk/aws-rds:lowercaseDbIdentifier": true,
"@aws-cdk/aws-lambda:recognizeVersionProps": true,
"@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2_2021": true,
"@aws-cdk-containers/ecs-service-extensions:enableDefaultLogDriver": true,
"@aws-cdk/aws-ec2:uniqueImdsv2TemplateName": true,
"@aws-cdk/aws-iam:minimizePolicies": true,
"@aws-cdk/core:target-partitions": [
"aws",
"aws-cn"
],
"@aws-cdk/core:newStyleStackSynthesis": true
},
"qualifier": "sample-app",
"toolkitStackName": "sample-app-cdk-toolkit"
}
Run cdk bootstrap and observe resources being created using the default qualifier.
Possible Solution
Unkown, I'd assume the CLI should plug in the qualifier value from cdk.json if not explicitly provided as an option to the command.
Additional Information/Context
No response
CDK CLI Version
2.113.0 (build ccd534a)
Framework Version
No response
Node.js Version
v20.9.0
OS
OSX 13.6 (22G120)
Language
TypeScript
Language Version
No response
Other information
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
@aws-cdk/coreRelated to core CDK functionalityRelated to core CDK functionalitybugThis issue is a bug.This issue is a bug.effort/mediumMedium work item – several days of effortMedium work item – several days of effortneeds-reviewp1package/toolsRelated to AWS CDK Tools or CLIRelated to AWS CDK Tools or CLI