Skip to content

aws-sns: return Subscription when calling ITopic.addSubscription  #20657

@jonnekaunisto

Description

@jonnekaunisto

Describe the feature

return Subscription when calling ITopic.addSubscription

Use Case

I want to make the SQS policy deploy before the Subscription gets created so that SNS doesn't fail to deliver messages.

Proposed Solution

Currently the subscription that is created is not returned: https://github.com/aws/aws-cdk/blob/v1.159.0/packages/%40aws-cdk/aws-sns/lib/topic-base.ts#L80

Adding a return would solve the problem.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2

Environment details (OS name and version, etc.)

Mac OS

Metadata

Metadata

Assignees

No one assigned

    Labels

    @aws-cdk/aws-snsRelated to Amazon Simple Notification Serviceeffort/smallSmall work item – less than a day of effortfeature-requestA feature should be added or improved.good first issueRelated to contributions. See CONTRIBUTING.mdp1

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions