-
Notifications
You must be signed in to change notification settings - Fork 4.5k
(cloudwatch): Unit.NONE does not mean "No unit" #20112
Copy link
Copy link
Closed
Labels
documentationThis is a problem with documentation.This is a problem with documentation.effort/smallSmall work item – less than a day of effortSmall work item – less than a day of effortgood first issueRelated to contributions. See CONTRIBUTING.mdRelated to contributions. See CONTRIBUTING.mdp2package/toolsRelated to AWS CDK Tools or CLIRelated to AWS CDK Tools or CLI
Metadata
Metadata
Assignees
Labels
documentationThis is a problem with documentation.This is a problem with documentation.effort/smallSmall work item – less than a day of effortSmall work item – less than a day of effortgood first issueRelated to contributions. See CONTRIBUTING.mdRelated to contributions. See CONTRIBUTING.mdp2package/toolsRelated to AWS CDK Tools or CLIRelated to AWS CDK Tools or CLI
Describe the bug
In CDK it states
Unit.NONEmeans "No unit", but it results in "None" instead of "No unit" (and no data is returned when Unit == None) .Expected Behavior
The documentation states
Unit.NONEmeans "No unit", so it is expected that when usingUnit.NONEin CDK stack for alarm, the unit will be "No unit".Current Behavior
In CDK it states
Unit.NONEmeans "No unit"The following screenshot shows the deployed alarm having Unit "None" instead of "No unit" (and no data is returned when Unit == None).
Reproduction Steps
Unit.NONEfor an alarm.Possible Solution
Either fixed the documentation Unit.NONE != No Unit, or make Unit.NoUnit an option.
Additional Information/Context
No response
CDK CLI Version
2.21.1 (build a6ee543)
Framework Version
No response
Node.js Version
v16.14.2
OS
Ubuntu 20.04.4
Language
Typescript
Language Version
Version 4.6.3
Other information
No response