fix(aws_applicationautoscaling): Add missing members to PredefinedMetric enum by StevenSmiley · Pull Request #18978 · aws/aws-cdk

StevenSmiley · 2022-02-15T22:00:40Z

Five predefined metrics for autoscaling using target tracking metrics are supported by CloudFormation but missing from the CDK enum PredefinedMetric. Fixes #18969

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2022-02-15T22:00:43Z

mergify · 2022-02-15T22:01:14Z

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

comcalvi

Thanks for the PR! It looks great, just one fairly minor comment.

comcalvi · 2022-03-10T01:42:50Z

packages/@aws-cdk/aws-applicationautoscaling/lib/target-tracking-scaling-policy.ts

+   * APPSTREAM_AVERAGE_CAPACITY_UTILIZATION
+   * @see https://docs.aws.amazon.com/autoscaling/application/APIReference/API_PredefinedMetricSpecification.html
+   */
+  APPSTREAM_AVERAGE_CAPACITY_UTILIZATION = 'AppStreamAverageCapacityUtilization',


Could we get more descriptive docs here? I know the existing enum members suffer from this as well, but you don't need to do those; just the new members will be fine. This comment goes for all the new properties.

Sure, I have updated the docs to describe the metrics to which these members refer.

Pull request has been modified.

comcalvi

thanks for the contribution, this looks great

mergify · 2022-03-31T20:54:42Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-04-01T01:58:54Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: cc96927
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-04-01T01:58:59Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/bump/1.152.0/CHANGELOG.md) For convenience, extracted the relevant CHANGELOG entry: ## [1.152.0](v1.151.0...v1.152.0) (2022-04-06) ### Features * **cfnspec:** cloudformation spec v63.0.0 ([#19679](#19679)) ([dba96a9](dba96a9)) * **cfnspec:** cloudformation spec v65.0.0 ([#19745](#19745)) ([796fc64](796fc64)) * **cli:** add --build option ([#19663](#19663)) ([eb9b8e2](eb9b8e2)), closes [#19667](#19667) * **cli:** preview of `cdk import` ([#17666](#17666)) ([4f12209](4f12209)) * **core:** throw error when stack name exceeds max length ([#19725](#19725)) ([1ffd45e](1ffd45e)) * **eks:** add k8s v1.22 ([#19756](#19756)) ([9a518c5](9a518c5)) * **opensearch:** Add latest Opensearch Version 1.2 ([#19749](#19749)) ([a2ac36e](a2ac36e)) * add new integration test runner ([#19754](#19754)) ([1b4d010](1b4d010)) * **eks:** alb-controller v2.4.1 ([#19653](#19653)) ([1ec08df](1ec08df)) * **lambda:** add support for ephemeral storage ([#19552](#19552)) ([f1d9b6a](f1d9b6a)), closes [#19605](#19605) * **s3:** EventBridge bucket notifications ([#18614](#18614)) ([d8e602b](d8e602b)), closes [#18076](#18076) * **synthetics:** new puppeteer 3.5 runtime ([#19673](#19673)) ([ce2b91b](ce2b91b)), closes [#19634](#19634) ### Bug Fixes * **aws_applicationautoscaling:** Add missing members to PredefinedMetric enum ([#18978](#18978)) ([75a6fa7](75a6fa7)), closes [#18969](#18969) * **cli:** apps with many resources scroll resource output offscreen ([#19742](#19742)) ([053d22c](053d22c)), closes [#19160](#19160) * **cli:** support attributes of DynamoDB Tables for hotswapping ([#19620](#19620)) ([2321ece](2321ece)), closes [#19421](#19421) * **cloudwatch:** automatic metric math label cannot be suppressed ([#17639](#17639)) ([7fa3bf2](7fa3bf2)) * **codedeploy:** add name validation for Application, Deployment Group and Deployment Configuration ([#19473](#19473)) ([9185042](9185042)) * **codedeploy:** the Service Principal is wrong in isolated regions ([#19729](#19729)) ([7e9a43d](7e9a43d)), closes [#19399](#19399) * **core:** `Fn.select` incorrectly short-circuits complex expressions ([#19680](#19680)) ([7f26fad](7f26fad)) * **core:** detect and resolve stringified number tokens ([#19578](#19578)) ([7d9ab2a](7d9ab2a)), closes [#19546](#19546) [#19550](#19550) * **core:** reduce CFN template indent size to save bytes ([#19656](#19656)) ([fd63ca3](fd63ca3)) * **ecs:** 'desiredCount' and 'ephemeralStorageGiB' cannot be tokens ([#19453](#19453)) ([c852239](c852239)), closes [#16648](#16648) * **ecs:** remove unnecessary error when adding volume to external task definition ([#19774](#19774)) ([5446ded](5446ded)), closes [#19259](#19259) * **iam:** policies aren't minimized as far as possible ([#19764](#19764)) ([876ed8a](876ed8a)), closes [#19751](#19751) * **logs:** Faulty Resource Policy Generated ([#19640](#19640)) ([1fdf122](1fdf122)), closes [#17544](#17544)

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/bump/2.20.0/CHANGELOG.md) For convenience, extracted the relevant CHANGELOG entry: ## [2.20.0](v2.19.0...v2.20.0) (2022-04-07) ### Features * **cfnspec:** cloudformation spec v63.0.0 ([#19679](#19679)) ([dba96a9](dba96a9)) * **cfnspec:** cloudformation spec v65.0.0 ([#19745](#19745)) ([796fc64](796fc64)) * **cli:** add --build option ([#19663](#19663)) ([eb9b8e2](eb9b8e2)), closes [#19667](#19667) * **cli:** preview of `cdk import` ([#17666](#17666)) ([4f12209](4f12209)) * **core:** throw error when stack name exceeds max length ([#19725](#19725)) ([1ffd45e](1ffd45e)) * **eks:** add k8s v1.22 ([#19756](#19756)) ([9a518c5](9a518c5)) * **opensearch:** Add latest Opensearch Version 1.2 ([#19749](#19749)) ([a2ac36e](a2ac36e)) * add new integration test runner ([#19754](#19754)) ([1b4d010](1b4d010)) * **eks:** alb-controller v2.4.1 ([#19653](#19653)) ([1ec08df](1ec08df)) * **lambda:** add support for ephemeral storage ([#19552](#19552)) ([f1d9b6a](f1d9b6a)), closes [#19605](#19605) * **s3:** EventBridge bucket notifications ([#18614](#18614)) ([d8e602b](d8e602b)), closes [#18076](#18076) ### Bug Fixes * **aws_applicationautoscaling:** Add missing members to PredefinedMetric enum ([#18978](#18978)) ([75a6fa7](75a6fa7)), closes [#18969](#18969) * **cli:** apps with many resources scroll resource output offscreen ([#19742](#19742)) ([053d22c](053d22c)), closes [#19160](#19160) * **cli:** support attributes of DynamoDB Tables for hotswapping ([#19620](#19620)) ([2321ece](2321ece)), closes [#19421](#19421) * **cloudwatch:** automatic metric math label cannot be suppressed ([#17639](#17639)) ([7fa3bf2](7fa3bf2)) * **codedeploy:** add name validation for Application, Deployment Group and Deployment Configuration ([#19473](#19473)) ([9185042](9185042)) * **codedeploy:** the Service Principal is wrong in isolated regions ([#19729](#19729)) ([7e9a43d](7e9a43d)), closes [#19399](#19399) * **core:** `Fn.select` incorrectly short-circuits complex expressions ([#19680](#19680)) ([7f26fad](7f26fad)) * **core:** detect and resolve stringified number tokens ([#19578](#19578)) ([7d9ab2a](7d9ab2a)), closes [#19546](#19546) [#19550](#19550) * **core:** reduce CFN template indent size to save bytes ([#19656](#19656)) ([fd63ca3](fd63ca3)) * **ecs:** 'desiredCount' and 'ephemeralStorageGiB' cannot be tokens ([#19453](#19453)) ([c852239](c852239)), closes [#16648](#16648) * **ecs:** remove unnecessary error when adding volume to external task definition ([#19774](#19774)) ([5446ded](5446ded)), closes [#19259](#19259) * **iam:** policies aren't minimized as far as possible ([#19764](#19764)) ([876ed8a](876ed8a)), closes [#19751](#19751) * **logs:** Faulty Resource Policy Generated ([#19640](#19640)) ([1fdf122](1fdf122)), closes [#17544](#17544)

…ric enum (aws#18978) Five predefined metrics for autoscaling using target tracking metrics are supported by CloudFormation but missing from the CDK enum PredefinedMetric. Fixes aws#18969 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

StevenSmiley added 2 commits February 14, 2022 16:49

Add missing member to PredefinedMetric enum

0d05465

Add missing enum members

2453b28

github-actions bot added the @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling label Feb 15, 2022

github-actions bot assigned comcalvi Feb 15, 2022

StevenSmiley changed the title ~~Add missing members to PredefinedMetric enum~~ fix(application_autoscaling): Add missing members to PredefinedMetric enum Feb 15, 2022

github-actions bot added the @aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling label Feb 15, 2022

StevenSmiley changed the title ~~fix(application_autoscaling): Add missing members to PredefinedMetric enum~~ fix(aws_applicationautoscaling): Add missing members to PredefinedMetric enum Feb 15, 2022

Merge branch 'master' into patch-1

04cfc95

rix0rrr added feature-request A feature should be added or improved. p1 and removed p1 feature-request A feature should be added or improved. @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling @aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling labels Mar 4, 2022

comcalvi previously requested changes Mar 10, 2022

View reviewed changes

Describe metrics

88bd0c9

comcalvi approved these changes Mar 14, 2022

View reviewed changes

comcalvi added the pr-linter/exempt-test The PR linter will not require test changes label Mar 31, 2022

Merge branch 'master' into patch-1

cc96927

mergify bot merged commit 75a6fa7 into aws:master Apr 1, 2022

StevenSmiley deleted the patch-1 branch April 3, 2022 02:15

iliapolo mentioned this pull request Apr 7, 2022

chore(release): 1.152.0 #19781

Merged

iliapolo mentioned this pull request Apr 7, 2022

chore(release): 2.20.0 #19801

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(aws_applicationautoscaling): Add missing members to PredefinedMetric enum#18978

fix(aws_applicationautoscaling): Add missing members to PredefinedMetric enum#18978
mergify[bot] merged 5 commits intoaws:masterfrom
StevenSmiley:patch-1

StevenSmiley commented Feb 15, 2022

Uh oh!

gitpod-io bot commented Feb 15, 2022

Uh oh!

mergify bot commented Feb 15, 2022

Uh oh!

comcalvi left a comment

Uh oh!

comcalvi Mar 10, 2022

Uh oh!

StevenSmiley Mar 10, 2022

Uh oh!

comcalvi left a comment

Uh oh!

mergify bot commented Mar 31, 2022

Uh oh!

aws-cdk-automation commented Apr 1, 2022

Uh oh!

mergify bot commented Apr 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

StevenSmiley commented Feb 15, 2022

Uh oh!

gitpod-io bot commented Feb 15, 2022

Uh oh!

mergify bot commented Feb 15, 2022

Uh oh!

comcalvi left a comment

Choose a reason for hiding this comment

Uh oh!

comcalvi Mar 10, 2022

Choose a reason for hiding this comment

Uh oh!

StevenSmiley Mar 10, 2022

Choose a reason for hiding this comment

Uh oh!

comcalvi left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Mar 31, 2022

Uh oh!

aws-cdk-automation commented Apr 1, 2022

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Apr 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants