-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Top-level L2 resources should have unmangled logical IDs #1687
Copy link
Copy link
Closed
Labels
@aws-cdk/coreRelated to core CDK functionalityRelated to core CDK functionalityeffort/smallSmall work item – less than a day of effortSmall work item – less than a day of effortfeature-requestA feature should be added or improved.A feature should be added or improved.package/cfnRelated to the CFN layer (L1)Related to the CFN layer (L1)pr/breaking-changeThis PR is a breaking change. It needs to be modified to be allowed in the current major version.This PR is a breaking change. It needs to be modified to be allowed in the current major version.
Description
Customers expect that when they add L2 resources directly to the Stack, the id they provide for the L2 will be the logical ID of the underlying L1 resource. This will also clean up the logical IDs of deCDK resource (#1618).
Aside from this being a huge breaking change, and we should probably allow people to disable this behavior for backwards compat. I don't see why we shouldn't implement this heuristic.
Change logical ID to "Default" (or ".") and then defaultChild (#2290) should be the way to access these resources.
@rix0rrr @RomainMuller @sam-goodwin what do you guys think?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
@aws-cdk/coreRelated to core CDK functionalityRelated to core CDK functionalityeffort/smallSmall work item – less than a day of effortSmall work item – less than a day of effortfeature-requestA feature should be added or improved.A feature should be added or improved.package/cfnRelated to the CFN layer (L1)Related to the CFN layer (L1)pr/breaking-changeThis PR is a breaking change. It needs to be modified to be allowed in the current major version.This PR is a breaking change. It needs to be modified to be allowed in the current major version.