-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[cli] cdk diff always reports diff if resource has non-ASCII characters #10523
Copy link
Copy link
Closed
Labels
blockedWork is blocked on this issue for this codebase. Other labels or comments may indicate why.Work is blocked on this issue for this codebase. Other labels or comments may indicate why.bugThis issue is a bug.This issue is a bug.effort/mediumMedium work item – several days of effortMedium work item – several days of effortneeds-cfnThis issue is waiting on changes to CloudFormation before it can be addressed.This issue is waiting on changes to CloudFormation before it can be addressed.p1package/toolsRelated to AWS CDK Tools or CLIRelated to AWS CDK Tools or CLI
Metadata
Metadata
Assignees
Labels
blockedWork is blocked on this issue for this codebase. Other labels or comments may indicate why.Work is blocked on this issue for this codebase. Other labels or comments may indicate why.bugThis issue is a bug.This issue is a bug.effort/mediumMedium work item – several days of effortMedium work item – several days of effortneeds-cfnThis issue is waiting on changes to CloudFormation before it can be addressed.This issue is waiting on changes to CloudFormation before it can be addressed.p1package/toolsRelated to AWS CDK Tools or CLIRelated to AWS CDK Tools or CLI
cdk diffalways reports diff if resource has non-ASCII characters.Reproduction Steps
What did you expect to happen?
cdk diffreports no diff, when resources are in sync.What actually happened?
cdk diffalways reports diff, even when resources are in sync.Environment
Other
Guessing from its behavior, it seems like correct encoding(UTF-8?) is not specified while fetching current template from CloudFormation. So that the non-ASCII characters are converted to the "?" character and treated as if it is having diffs.This is 🐛 Bug Report