[core] "Full docker build" no longer works #10438
Description
As detailed in Contributing.md, I should be able to initiate a full build of CDK under Docker with docker build -t aws-cdk .. This does not work because scripts/check-prerequisites.sh attempts to connect to the Docker daemon and run docker ps, which is impossible in a Docker container.
I've reproduced this in Docker on Windows and with Podman on Fedora 32.
Reproduction Steps
$ git clone https://github.com/aws/aws-cdk.git
$ cd aws-cdk
$ docker build -t aws-cdk . What did you expect to happen?
CDK gets built.
What actually happened?
[4/4] Building fresh packages...
Done in 143.03s.
git: 'secrets' is not a git command. See 'git --help'.
git-secrets scan ok
Checking if node is installed... Ok
Checking node version... Ok
Checking if yarn is installed... Ok
Checking yarn version... Ok
Checking if javac is installed... Ok
Checking javac version... Ok
Checking if mvn is installed... Ok
Checking mvn version... Ok
Checking if dotnet is installed... Ok
Checking dotnet version... Ok
Checking if python3 is installed... Ok
Checking python3 version... Ok
Checking if ruby is installed... Ok
Checking ruby version... Ok
Checking if docker is installed... Ok
Checking if docker is running... Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
The command '/bin/sh -c ./build.sh ${BUILD_ARGS} && ./link-all.sh' returned a non-zero code: 1You can't connect to the Docker daemon because we're already in a Docker container.
Environment
- CLI Version :
aws-cli/2.0.25 Python/3.7.7 Windows/10 botocore/2.0.0dev29 - Framework Version: d45a57c
- Node.js Version: v12.16.1
- OS : Windows 10, and also Fedora 32
- Language (Version): N/A
Other
I believe this was introduced when the scripts/check-prerequisites.sh script was added in #8929 on July 14, 2020. If I blank out this entire script with exit 0, the build succeeds.
This is 🐛 Bug Report