Skip to content

[aws-certificatemanager] validationDomains does not need to be supplied for PCA certificates  #10076

@mifisignal

Description

@mifisignal

When using tokens for domain names, attempting to create a new ACM certificate throws the error:

When using Tokens for domain names, 'validationDomains' needs to be supplied

This makes sense when generating a public certificate, but not for a private certificate issued by Private Certificate Authority (PCA) since these certificates are not validated.

Reproduction Steps

    const serviceCertificate = new acm.Certificate(
      this,
      "ServiceCertificate",
      {
        domainName: `${sdService.serviceName}.${namespace.namespaceName}`,
      }
    );
    // App Mesh Gateways and Virtual Nodes can only use PCA or file-backed certificates
    (serviceCertificate.node
      .defaultChild as cdk.CfnResource).addPropertyOverride(
      "CertificateAuthorityArn",
      CertificateAuthorityArn
    );

What did you expect to happen?

What actually happened?

Environment

  • CLI Version : 1.61.1
  • Framework Version: 1.61.1
  • Node.js Version: 12.18.1
  • OS : MacOS Catalina
  • Language (Version): TypeScript

This is 🐛 Bug Report

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions