Add change requests

Pedro Pimentel · Pedro Pimentel · commit fa904850bc16 · 2021-11-29T19:37:32.000-03:00
diff --git a/packages/@aws-cdk/aws-cloudwatch/lib/dashboard.ts b/packages/@aws-cdk/aws-cloudwatch/lib/dashboard.ts
@@ -76,10 +76,10 @@ export interface DashboardProps {
  */
 export class Dashboard extends Resource {
   /**
-   * The name of this queue
+   * The name of this dashboard
    * @attribute
   */
-  public readonly dashboardName?: string | undefined;
+  public readonly dashboardName: string;
   private readonly rows: IWidget[] = [];
 
   constructor(scope: Construct, id: string, props: DashboardProps = {}) {
@@ -113,7 +113,8 @@ export class Dashboard extends Resource {
       }),
     });
 
-    this.dashboardName = dashboard.dashboardName;
+    this.dashboardName = this.getResourceNameAttribute(dashboard.ref);
+    // dashboard.dashboardName;
 
     (props.widgets || []).forEach(row => {
       this.addWidgets(...row);
diff --git a/packages/@aws-cdk/aws-cloudwatch/test/dashboard.test.ts b/packages/@aws-cdk/aws-cloudwatch/test/dashboard.test.ts
@@ -161,21 +161,6 @@ describe('Dashboard', () => {
 
   });
 
-  test('DashboardName is exposed correctly when provided', () => {
-    // GIVEN
-    const app = new App();
-    const stack = new Stack(app, 'MyStack');
-
-    // WHEN
-    const dash = new Dashboard(stack, 'MyDashboard', {
-      dashboardName: 'MyCustomDashboardName',
-    });
-
-    // THEN
-    expect(dash.dashboardName).toEqual('MyCustomDashboardName');
-
-  });
-
   test('throws if DashboardName is not valid', () => {
     // GIVEN
     const app = new App();
