fix(cli): cdk deploy is listing deprecated ids

rix0rrr · rix0rrr · commit dee720d878bf · 2021-07-16T13:59:29.000+02:00
The new recommended way of selecting stacks is by their construct path,
however when prompted the CLI is printing the deprecated identifiers.
diff --git a/packages/aws-cdk/lib/api/cxapp/cloud-assembly.ts b/packages/aws-cdk/lib/api/cxapp/cloud-assembly.ts
@@ -156,7 +156,7 @@ export class CloudAssembly {
           return new StackCollection(this, topLevelStacks);
         } else {
           throw new Error('Since this app includes more than a single stack, specify which stacks to use (wildcards are supported) or specify `--all`\n' +
-          `Stacks: ${stacks.map(x => x.id).join(' ')}`);
+          `Stacks: ${stacks.map(x => x.hierarchicalId).join(' · ')}`);
         }
       default:
         throw new Error(`invalid default behavior: ${defaultSelection}`);
diff --git a/packages/aws-cdk/test/api/cloud-assembly.test.ts b/packages/aws-cdk/test/api/cloud-assembly.test.ts
@@ -86,6 +86,15 @@ test('select behavior: single', async () => {
     .rejects.toThrow('Since this app includes more than a single stack, specify which stacks to use (wildcards are supported) or specify `--all`');
 });
 
+test('stack list error contains node paths', async () => {
+  // GIVEN
+  const cxasm = await testCloudAssembly();
+
+  // WHEN
+  await expect(cxasm.selectStacks({ patterns: [] }, { defaultBehavior: DefaultSelection.OnlySingle }))
+    .rejects.toThrow('withouterrorsNODEPATH');
+});
+
 test('select behavior: repeat', async () => {
   // GIVEN
   const cxasm = await testCloudAssembly();
@@ -147,6 +156,7 @@ async function testCloudAssembly({ env }: { env?: string, versionReporting?: boo
   const cloudExec = new MockCloudExecutable({
     stacks: [{
       stackName: 'withouterrors',
+      displayName: 'withouterrorsNODEPATH',
       env,
       template: { resource: 'noerrorresource' },
     },

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ export class CloudAssembly {`
`156`	`156`	`return new StackCollection(this, topLevelStacks);`
`157`	`157`	`} else {`
`158`	`158`	throw new Error('Since this app includes more than a single stack, specify which stacks to use (wildcards are supported) or specify `--all`\n' +
`159`		- `Stacks: ${stacks.map(x => x.id).join(' ')}`);
	`159`	+ `Stacks: ${stacks.map(x => x.hierarchicalId).join(' · ')}`);
`160`	`160`	`}`
`161`	`161`	`default:`
`162`	`162`	throw new Error(`invalid default behavior: ${defaultSelection}`);