Add integration test

Elad Ben-Israel · Elad Ben-Israel · commit a1473ae61dea · 2020-02-19T11:20:16.000+02:00
diff --git a/packages/aws-cdk/test/integ/cli/app/app.js b/packages/aws-cdk/test/integ/cli/app/app.js
@@ -6,6 +6,7 @@ const iam = require('@aws-cdk/aws-iam');
 const sns = require('@aws-cdk/aws-sns');
 const lambda = require('@aws-cdk/aws-lambda');
 const docker = require('@aws-cdk/aws-ecr-assets');
+const { StackWithNestedStack } = require('./nested-stack');
 
 const stackPrefix = process.env.STACK_NAME_PREFIX || 'cdk-toolkit-integration';
 
@@ -179,4 +180,6 @@ if (process.env.ENABLE_VPC_TESTING) { // Gating so we don't do context fetching
 
 new ConditionalResourceStack(app, `${stackPrefix}-conditional-resource`)
 
+new StackWithNestedStack(app, `${stackPrefix}-with-nested-stack`);
+
 app.synth();
diff --git a/packages/aws-cdk/test/integ/cli/app/nested-stack.js b/packages/aws-cdk/test/integ/cli/app/nested-stack.js
@@ -0,0 +1,20 @@
+const cfn = require('@aws-cdk/aws-cloudformation');
+const sns = require('@aws-cdk/aws-sns');
+const { Stack } = require('@aws-cdk/core');
+
+class StackWithNestedStack extends Stack {
+  constructor(scope, id) {
+    super(scope, id);
+    new MyNestedStack(this, 'MyNested');
+  }
+}
+
+class MyNestedStack extends cfn.NestedStack {
+  constructor(scope, id) {
+    super(scope, id);
+
+    new sns.Topic(this, 'MyTopic');
+  }
+}
+
+exports.StackWithNestedStack = StackWithNestedStack;
diff --git a/packages/aws-cdk/test/integ/cli/common.bash b/packages/aws-cdk/test/integ/cli/common.bash
@@ -78,6 +78,7 @@ function prepare_fixture() {
         @aws-cdk/aws-lambda \
         @aws-cdk/aws-ssm \
         @aws-cdk/aws-ecr-assets \
+        @aws-cdk/aws-cloudformation \
         @aws-cdk/aws-ec2
 
     echo "| setup complete at: $PWD"
@@ -91,6 +92,7 @@ function cleanup() {
   cleanup_stack ${STACK_NAME_PREFIX}-test-1
   cleanup_stack ${STACK_NAME_PREFIX}-test-2
   cleanup_stack ${STACK_NAME_PREFIX}-iam-test
+  cleanup_stack ${STACK_NAME_PREFIX}-with-nested-stack
 }
 
 function setup() {
diff --git a/packages/aws-cdk/test/integ/cli/test-cdk-fast-deploy.sh b/packages/aws-cdk/test/integ/cli/test-cdk-fast-deploy.sh
@@ -0,0 +1,51 @@
+#!/bin/bash
+set -euo pipefail
+scriptdir=$(cd $(dirname $0) && pwd)
+source ${scriptdir}/common.bash
+# ----------------------------------------------------------
+# this test verifies that deployment is skipped when the template did not
+# change, and that `--force` can be used to override this behavior.
+
+setup
+
+# we are using a stack with a nested stack because CFN will always attempt to
+# update a nested stack, which will allow us to verify that updates are actually
+# skipped unless --force is specified.
+stack_name="${STACK_NAME_PREFIX}-with-nested-stack"
+
+get_last_changeset() {
+    aws cloudformation describe-stacks --stack-name ${stack_name} --query 'Stacks[0].ChangeSetId'
+}
+
+# deploy once
+echo "============================================================"
+echo " deploying stack"
+echo "============================================================"
+cdk deploy -v ${stack_name}
+changeset1=$(get_last_changeset)
+echo "changeset1=${changeset1}"
+
+echo "============================================================"
+echo " deploying the same stack again (no change)"
+echo "============================================================"
+cdk deploy -v ${stack_name}
+changeset2=$(get_last_changeset)
+if [ "${changeset2}" != "${changeset1}" ]; then
+    echo "TEST FAILED: expected the 'cdk deploy' will skip deployment because the app did not change"
+    exit 1
+fi
+
+echo "============================================================"
+echo " deploying the same stack again (no change, --force)"
+echo "============================================================"
+cdk deploy --force -v ${stack_name}
+changeset3=$(get_last_changeset)
+if [ "${changeset3}" == "${changeset1}" ]; then
+    echo "TEST FAILED: expected --force to create a new changeset"
+    exit 1
+fi
+
+# destroy
+cdk destroy -f ${stack_name}
+
+echo "✅  success"
