Skip to content

Commit 910a7d3

Browse files
committed
Commited all of suggestions
1 parent 7dc422d commit 910a7d3

4 files changed

Lines changed: 9 additions & 10 deletions

File tree

packages/@aws-cdk-testing/framework-integ/test/aws-kms/test/integ.key-multi-region.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@ import { App, Stack } from 'aws-cdk-lib';
22
import * as kms from 'aws-cdk-lib/aws-kms';
33
import { IntegTest } from '@aws-cdk/integ-tests-alpha';
44

5-
class TestStack extends Stack {
5+
class KmsKeyMultiRegionStack extends Stack {
66
constructor(scope: App) {
7-
super(scope, 'TestStack');
7+
super(scope, 'KmsKeyMultiRegionStack');
88
new kms.Key(this, 'key', {
99
multiRegion: true,
1010
});
1111
}
1212
}
1313

1414
const app = new App();
15-
const stack = new TestStack(app);
15+
const stack = new KmsKeyMultiRegionStack(app);
1616

1717
new IntegTest(app, 'kms-key-multi-region', {
1818
testCases: [stack],

packages/aws-cdk-lib/aws-kms/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ const key = new kms.Key(this, 'MyKey', {
4242
```
4343

4444

45-
Creates a multi-Region primary key:
45+
Create a multi-Region primary key:
4646

4747
```ts
4848
const key = new kms.Key(this, 'MyKey', {

packages/aws-cdk-lib/aws-kms/lib/key.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -470,16 +470,15 @@ export interface KeyProps {
470470

471471
/**
472472
* Creates a multi-Region primary key that you can replicate in other AWS Regions.
473-
* You can't change the MultiRegion value after the KMS key is created.
474473
*
475-
* For a multi-Region key, set to this property to true.
476-
* For a single-Region key, omit this property or set it to false. The default value is false.
474+
* You can't change the `multiRegion` value after the KMS key is created.
477475
*
478-
* IMPORTANT: If you change the value of the MultiRegion property on an existing KMS key, the update request fails,
476+
* IMPORTANT: If you change the value of the `multiRegion` property on an existing KMS key, the update request fails,
479477
* regardless of the value of the UpdateReplacePolicy attribute.
480478
* This prevents you from accidentally deleting a KMS key by changing an immutable property value.
481479
*
482-
* @default - false
480+
* @default false
481+
* @see https://docs.aws.amazon.com/kms/latest/developerguide/multi-region-keys-overview.html
483482
*/
484483
readonly multiRegion?: boolean;
485484

packages/aws-cdk-lib/aws-kms/test/key.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ test('fails if key policy has no IAM principals', () => {
646646
expect(() => app.synth()).toThrow(/A PolicyStatement used in a resource-based policy must specify at least one IAM principal/);
647647
});
648648

649-
test('creates a multi-Region primary key', () => {
649+
test('multi-region primary key', () => {
650650
const stack = new cdk.Stack();
651651
new kms.Key(stack, 'MyKey', {
652652
multiRegion: true,

0 commit comments

Comments
 (0)