Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Contributor
Author
|
Hola @bwagner5 long time no see :) |
bwagner5
approved these changes
Feb 24, 2025
Contributor
bwagner5
left a comment
There was a problem hiding this comment.
lgtm
I added a conversion if an in32 is passed to convert to an int64 to be checked if the instance spec value is an in64.
Contributor
Author
|
thanks @bwagner5 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #413
Description of changes: Do exactly what we do for
GpuMemoryRangeas that one works fine. which means we use theInt32RangeFilterBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Here's the output: