Merged
Conversation
a deadlock could occur if a child, after beginning to tear down via a `ScopeClosing` exception delivered from its parent, ultimately wants to die with a different exception (e.g. a synchronous exception thrown during a registered cleanup action). this PR makes a child thread that has an exception to propagate to its parent first check to see if its parent's scope is closed, and if it is, elects to communicate the exception via `childExceptionVar` rather than use `throwTo`
1dbdc4a to
e172333
Compare
tstat
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a deadlock could occur if a child, after beginning to tear down via a
ScopeClosingexception delivered from its parent, ultimately wants to die with a different exception (e.g. a synchronous exception thrown during a registered cleanup action).this PR makes a child thread that has an exception to propagate to its parent first check to see if its parent's scope is closed, and if it is, elects to communicate the exception via
childExceptionVarrather than usethrowTo