Closed
Conversation
This was meant to explicitly test/check the examples, when caching for generated output was added (02f894c), but is no longer useful/required anymore, especially since it only works when run from tests/examples anyway (what Travis is doing explicitly).
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #2548 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 497 497
Lines 33714 33714
=======================================
Hits 28511 28511
Misses 5203 5203
|
Member
Author
|
Hmm, I think it should be kept, but get fixed instead (basically making it use what Travis does, enforcing STRICT_TESTS). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was meant to explicitly test/check the examples, when caching for
generated output was added (02f894c), but is no longer useful/required
anymore, especially since it only works when run from tests/examples
anyway (what Travis is doing explicitly).