startExpanded=True expands all nodes by default#56
Closed
saetsac wants to merge 3 commits intoawendland:masterfrom
Closed
startExpanded=True expands all nodes by default#56saetsac wants to merge 3 commits intoawendland:masterfrom
saetsac wants to merge 3 commits intoawendland:masterfrom
Conversation
|
is there any chance this pull request will be merged? |
Owner
|
Apologies for the massive delays in reviewing these PRs, I will attempt to review this on the weekend. Thank you for the addition to the project! |
|
Don't mean to keep nagging on this, but is this getting reviewed soon? |
awendland
added a commit
that referenced
this pull request
Jan 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change startExpanded behavior so we could expand all child nodes automatically
Description
Inherits startExpanded from parent element. Tracks element by $index (without it arrays were failing to expand)
Motivation and Context
startExpanded by expanding only the top element is kind of a strange thing. We need to expand everything at once.
How Has This Been Tested?
Unittests 4/4 pass
Types of changes
Checklist: