fix: prevent button text wrapping on narrow devices#401
Merged
Conversation
RoundedButton text would wrap to multiple lines on narrow screens (iPhone 13 mini) because Text had no line limit set. Add `.lineLimit(1)` to ensure text stays on one line. Fixes awaseem#399
Owner
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #399 — Support button text wraps to two lines on narrow devices (iPhone 13 mini)
Root Cause
In
RoundedButton.swift, theText(text)component had no line limit set. On narrow screens where the button width is constrained (alongside the gear button and padding), "Support" wraps to the next line.Fix
Added
.lineLimit(1)to the Text inRoundedButton.swift(line 57). This prevents text from wrapping while preserving the rest of the button's existing layout behavior.Before
After
Testing
If this fix helped, consider buying me a coffee! ☕
