Skip to content

allow a custom map type to declare DeepCopy func#87

Closed
ndeloof wants to merge 2 commits intoawalterschulze:mainfrom
ndeloof:main
Closed

allow a custom map type to declare DeepCopy func#87
ndeloof wants to merge 2 commits intoawalterschulze:mainfrom
ndeloof:main

Conversation

@ndeloof
Copy link
Copy Markdown
Contributor

@ndeloof ndeloof commented Jun 6, 2024

This PR allows a type alias (type foo map[string]bar) to declare a custom DeepCopy method

ndeloof added 2 commits June 6, 2024 15:56
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@awalterschulze
Copy link
Copy Markdown
Owner

All paths have changed, so I don't think this will work

@ndeloof
Copy link
Copy Markdown
Contributor Author

ndeloof commented Jun 20, 2024

I had to change go module source so I can use my fork in compose-go
the relevant changes are in https://github.com/awalterschulze/goderive/pull/87/files#diff-42a8d5346bcda44c10315b1471d62a3a2cf7800840bfe6e51ac1724e51a52871L372-R394

@awalterschulze
Copy link
Copy Markdown
Owner

To make a pull request, you would need to fix the paths

@ndeloof
Copy link
Copy Markdown
Contributor Author

ndeloof commented Jun 20, 2024

created another PR from a branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants